Page MenuHomePhabricator

enclink: check contents of symlinks not just size in case of fcrypt
ClosedPublic

Authored by cschuhen on Mar 10 2021, 1:17 AM.

Details

Summary

Check content of symlinks because st_size may indicate the size of encrypted
data which does not match actual link value.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

cschuhen created this revision.Mar 10 2021, 1:17 AM

This is a fixed version of D9965 relating to issue6456.

Alphare accepted this revision.Mar 15 2021, 7:47 AM
Alphare added a subscriber: Alphare.

This looks good, thanks!
Please abandon D9965 as well.

BTW this should go to the stable branch!
I've sent my fix for the (existing) Rust implementation as a dependent diff.

This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.