( )⚙ D10011 blackbox: Remove misleading quotes in config example

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10011

blackbox: Remove misleading quotes in config example
ClosedPublic

Authored by SimonSapin on Feb 17 2021, 7:58 AM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHG36f3a64846c8: blackbox: Remove misleading quotes in config example
rHGc05ed3836c31: blackbox: Remove misleading quotes in config example
Summary

This example previously looked like quotes were part of configuration file
syntax, and the parsed date-format value was the part inside of them.
This is not the case: config syntax only parses quotes in list values.
Instead using that config would result in literal quotes being written to
.hg/blackbox.log as part of the date format.

This changes the example to what was probably intended.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

SimonSapin created this revision.Feb 17 2021, 7:58 AM
Alphare accepted this revision.Feb 18 2021, 4:52 AM
baymax updated this revision to Diff 25679.Feb 19 2021, 6:29 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

SimonSapin added a commit: rHGc05ed3836c31: blackbox: Remove misleading quotes in config example.Feb 24 2021, 11:10 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHGc05ed3836c31: blackbox: Remove misleading quotes in config example (authored by SimonSapin). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/blackbox.py (2 lines)

Diff 25878

hgext/blackbox.py

# limit the size of a log file # limit the size of a log file
maxsize = 1.5 MB maxsize = 1.5 MB
# rotate up to N log files when the current one gets too big # rotate up to N log files when the current one gets too big
maxfiles = 3 maxfiles = 3
[blackbox] [blackbox]
# Include nanoseconds in log entries with %f (see Python function # Include nanoseconds in log entries with %f (see Python function
# datetime.datetime.strftime) # datetime.datetime.strftime)
date-format = '%Y-%m-%d @ %H:%M:%S.%f' date-format = %Y-%m-%d @ %H:%M:%S.%f
""" """
from __future__ import absolute_import from __future__ import absolute_import
import re import re
from mercurial.i18n import _ from mercurial.i18n import _