This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10121

releasenotes: use the right API to access the 'sections'
ClosedPublic

Authored by marmoute on Mar 6 2021, 12:32 AM.

Details

Reviewers
pulkit
martinvonz
Group Reviewers
hg-reviewers
Commits
rHG88bd085cf2f8: releasenotes: use the right API to access the 'sections'
Summary

Preventing direct access to the underlying dict fix a breakage introduced by the
refactoring in d3df397e7a59.

This changeset is similar to 271dfcb98544, 5272542196cc and f7621fa14b84. The
breackage of releasenotes.py stayed under my radar as the CI did not have
fuzzywuzzy installed. (Something that is about to be fixed).

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Mar 6 2021, 12:32 AM
marmoute retitled this revision from releasenotes: use the right APO to access the 'sections' to releasenotes: use the right API to access the 'sections'.Mar 6 2021, 1:47 AM
pulkit accepted this revision.Mar 6 2021, 9:56 AM
This revision is now accepted and ready to land.Mar 6 2021, 9:56 AM
martinvonz accepted this revision.Mar 8 2021, 11:53 AM
martinvonz added a subscriber: martinvonz.

Thanks!

Revision Contents
Changeset List

PathPackages
Mhgext/releasenotes.py (2 lines)

Diff 26126

hgext/releasenotes.py

p.parse(f, data, sections, remap, read) p.parse(f, data, sections, remap, read)
else: else:
raise error.Abort( raise error.Abort(
_(b".hgreleasenotes file \'%s\' not found") % repo.pathto(f) _(b".hgreleasenotes file \'%s\' not found") % repo.pathto(f)
) )
if b'.hgreleasenotes' in ctx: if b'.hgreleasenotes' in ctx:
read(b'.hgreleasenotes') read(b'.hgreleasenotes')
return p[b'sections'] return p.items(b'sections')
def checkadmonitions(ui, repo, directives, revs): def checkadmonitions(ui, repo, directives, revs):
""" """
Checks the commit messages for admonitions and their validity. Checks the commit messages for admonitions and their validity.
.. abcd:: .. abcd::