This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10131

localrepo: fix conversion of exceptions to strings flagged by pytype
ClosedPublic

Authored by mharbison72 on Mar 8 2021, 6:44 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGd5d9177c0045: localrepo: fix conversion of exceptions to strings flagged by pytype
Summary

This is the same as e571fec5b606. I assume the 3 similar uses of bytestr in
__getitem__() are OK (even though pytype also flags them), because there is
apparently test coverage for 2 of the 3 cases.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Mar 8 2021, 6:44 PM
pulkit accepted this revision.Mar 9 2021, 12:15 AM
This revision is now accepted and ready to land.Mar 9 2021, 12:15 AM

Revision Contents
Changeset List

PathPackages
Mmercurial/localrepo.py (2 lines)

Diff 26157

mercurial/localrepo.py

try: try:
hgvfs.stat() hgvfs.stat()
except OSError as e: except OSError as e:
if e.errno != errno.ENOENT: if e.errno != errno.ENOENT:
raise raise
except ValueError as e: except ValueError as e:
# Can be raised on Python 3.8 when path is invalid. # Can be raised on Python 3.8 when path is invalid.
raise error.Abort( raise error.Abort(
_(b'invalid path %s: %s') % (path, pycompat.bytestr(e)) _(b'invalid path %s: %s') % (path, stringutil.forcebytestr(e))
) )
raise error.RepoError(_(b'repository %s not found') % path) raise error.RepoError(_(b'repository %s not found') % path)
requirements = _readrequires(hgvfs, True) requirements = _readrequires(hgvfs, True)
shared = ( shared = (
requirementsmod.SHARED_REQUIREMENT in requirements requirementsmod.SHARED_REQUIREMENT in requirements
or requirementsmod.RELATIVE_SHARED_REQUIREMENT in requirements or requirementsmod.RELATIVE_SHARED_REQUIREMENT in requirements