This is an archive of the discontinued Mercurial Phabricator instance.

command: clarify `postincoming` return and that return handling
ClosedPublic

Authored by marmoute on Mar 11 2021, 11:52 AM.

Details

Summary

The command should return None or a return code. The previous code was returning
boolean directly relying on the fact that True → 1 and False → 0. This is a
good road to troubles, so lets be explicit about that return.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Mar 11 2021, 11:52 AM
Alphare accepted this revision.Mar 16 2021, 5:42 AM
This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.