This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1022

sparse: add a test where sparse gets loaded in an non-sparse repository
ClosedPublic

Authored by simpkins on Oct 11 2017, 9:20 PM.
Tags
None
Subscribers
None

Details

Reviewers
mbthomas
Group Reviewers
Restricted Project
Commits
rFBHGX60a9c2d3456f: sparse: add a test where sparse gets loaded in an non-sparse repository
Summary

Add a test to make sure the sparse extension works with non-sparse
repositories. The share extension can cause the sparse extension to be loaded
even if the current working directory is not sparse.

Currently "hg diff" crashes in this scenario. After the changes in D788, it
now tries to run repo.sparsematch() without first checking to see if the
repository is actually a sparse repository.

Test Plan

Ran it.

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

simpkins created this revision.Oct 11 2017, 9:20 PM
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 11 2017, 9:20 PM
mbthomas accepted this revision.Oct 12 2017, 7:39 AM
This revision is now accepted and ready to land.Oct 12 2017, 7:39 AM
Closed by commit rFBHGX60a9c2d3456f: sparse: add a test where sparse gets loaded in an non-sparse repository (authored by simpkins). · Explain WhyOct 13 2017, 2:49 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
AMtests/test-sparse-notsparse.t (37 lines)

Diff 2660

tests/test-sparse-notsparse.t

  • This file was added.
Make sure the sparse extension does not break functionality when it gets
loaded in a non-sparse repository.
First create a base repository with sparse enabled.
$ hg init base
$ cd base
$ cat > .hg/hgrc <<EOF
> [extensions]
> sparse=$TESTDIR/../hgext3rd/sparse.py
> journal=
> EOF
$ echo a > file1
$ echo x > file2
$ hg ci -Aqm 'initial'
$ cd ..
Now create a shared working copy that is not sparse.
$ hg --config extensions.share= share base shared
updating working directory
2 files updated, 0 files merged, 0 files removed, 0 files unresolved
$ cd shared
$ cat > .hg/hgrc <<EOF
> [extensions]
> share=
> sparse=!
> journal=
> EOF
Make sure "hg diff" works in the non-sparse working directory.
$ echo z >> file1
$ hg diff |& grep -E 'Unknown exception|AttributeError'
** Unknown exception encountered with possibly-broken third-party extension sparse
AttributeError: 'localrepository' object has no attribute 'sparsematch'