This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10232

setdiscovery: rearrange code deciding if we will grow the sample
ClosedPublic

Authored by marmoute on Mar 17 2021, 6:16 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGf165105400d0: setdiscovery: rearrange code deciding if we will grow the sample
Summary

The new code is clearer and will make the next update simpler.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Mar 17 2021, 6:16 PM
pulkit accepted this revision.Mar 19 2021, 4:17 AM
This revision is now accepted and ready to land.Mar 19 2021, 4:17 AM
emmajackson2711 added a subscriber: emmajackson2711.Oct 19 2021, 6:17 AM

Hello I’m grateful to have read your content thank you. What a nice blog! I have enjoyed reading through the article although I landed on this site. If you are having issues in getting your proofreading services completed accurately then do not hesitate speech writer online and get your papers checked by the nursing assignment help australia in AU experts at GoAssignmentHelp. Visit - Assignment Help

Revision Contents
Changeset List

PathPackages
Mmercurial/setdiscovery.py (7 lines)

Diff 26538

mercurial/setdiscovery.py

if len(sample) == len(ownheads) and all(yesno): if len(sample) == len(ownheads) and all(yesno):
ui.note(_(b"all local changesets known remotely\n")) ui.note(_(b"all local changesets known remotely\n"))
ownheadhashes = [clnode(r) for r in ownheads] ownheadhashes = [clnode(r) for r in ownheads]
return ownheadhashes, True, srvheadhashes return ownheadhashes, True, srvheadhashes
# full blown discovery # full blown discovery
# if the server has a limit to its arguments size, we can't grow the sample. # if the server has a limit to its arguments size, we can't grow the sample.
hard_limit_sample = remote.limitedarguments
grow_sample = local.ui.configbool(b'devel', b'discovery.grow-sample') grow_sample = local.ui.configbool(b'devel', b'discovery.grow-sample')
hard_limit_sample = hard_limit_sample and grow_sample grow_sample = grow_sample and not remote.limitedarguments
randomize = ui.configbool(b'devel', b'discovery.randomize') randomize = ui.configbool(b'devel', b'discovery.randomize')
disco = partialdiscovery( disco = partialdiscovery(
local, ownheads, hard_limit_sample, randomize=randomize local, ownheads, not grow_sample, randomize=randomize
) )
if initial_head_exchange: if initial_head_exchange:
# treat remote heads (and maybe own heads) as a first implicit sample # treat remote heads (and maybe own heads) as a first implicit sample
# response # response
disco.addcommons(knownsrvheads) disco.addcommons(knownsrvheads)
disco.addinfo(zip(sample, yesno)) disco.addinfo(zip(sample, yesno))
full = not initial_head_exchange full = not initial_head_exchange
progress = ui.makeprogress(_(b'searching'), unit=_(b'queries')) progress = ui.makeprogress(_(b'searching'), unit=_(b'queries'))
while not disco.iscomplete(): while not disco.iscomplete():
if full or disco.hasinfo(): if full or disco.hasinfo():
if full: if full:
ui.note(_(b"sampling from both directions\n")) ui.note(_(b"sampling from both directions\n"))
else: else:
ui.debug(b"taking initial sample\n") ui.debug(b"taking initial sample\n")
samplefunc = disco.takefullsample samplefunc = disco.takefullsample
targetsize = fullsamplesize targetsize = fullsamplesize
if not hard_limit_sample: if grow_sample:
fullsamplesize = int(fullsamplesize * samplegrowth) fullsamplesize = int(fullsamplesize * samplegrowth)
else: else:
# use even cheaper initial sample # use even cheaper initial sample
ui.debug(b"taking quick initial sample\n") ui.debug(b"taking quick initial sample\n")
samplefunc = disco.takequicksample samplefunc = disco.takequicksample
targetsize = initialsamplesize targetsize = initialsamplesize
sample = samplefunc(ownheads, targetsize) sample = samplefunc(ownheads, targetsize)