Page MenuHomePhabricator

simplemerge: simplify
AbandonedPublic

Authored by joerg.sonnenberger on Mar 28 2021, 8:06 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

I hate to be That Guy but can you replace "simplify" in all these with some boilerplate about "compare revs and not ids because $REASON"? otherwise some enthusiastic architecture astronaut (probably me) is going to come back in the not-too-distant future and make it more generic and phrase things in terms of nodes rather than IDs.

(Generally my opinion is that we should be trying to hide revision numbers inside the repo storage layer, and try to traffic almost exclusively in nodes...)