This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10311

contrib: restore the `hg fix` configuration in the examples
ClosedPublic

Authored by mharbison72 on Apr 5 2021, 1:15 PM.

Download Raw Diff

Details

Reviewers

pulkit

Group Reviewers

hg-reviewers

Commits

rHG3d32b9759047: contrib: restore the `hg fix` configuration in the examples

Summary

After decc3bd3f20d, running black will DTRT, but running hg fix did nothing
(unless the example config file was %included, in which case it truncated the
file instead of formatting it). I'm not sure why that was happening, but let's
not leave a code shredder laying around.

Diff Detail

Repository

rHG Mercurial

Branch

default

Lint

No Linters Available

Unit

No Unit Test Coverage

Event Timeline

mharbison72 created this revision.Apr 5 2021, 1:15 PM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptApr 5 2021, 1:15 PM

Herald added a subscriber: mercurial-patches. · View Herald Transcript

mharbison72 added a child revision: D10312: tests: skip test-git-interop.t on Windows.Apr 5 2021, 11:55 PM

pulkit accepted this revision.Apr 11 2021, 5:24 PM

This revision is now accepted and ready to land.Apr 11 2021, 5:24 PM

mharbison72 added a commit: rHG3d32b9759047: contrib: restore the `hg fix` configuration in the examples.Apr 11 2021, 7:23 PM

Closed by commit rHG3d32b9759047: contrib: restore the `hg fix` configuration in the examples (authored by mharbison72). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			contrib/examples/fix.hgrc (2 lines)

Commit	Parents	Author	Summary	Date
5c6fba3b13b1	f7f1feb9b3c4	Matt Harbison		Apr 5 2021, 1:02 PM

Status	Author	Revision
Closed	mharbison72	D10312 tests: skip test-git-interop.t on Windows
Closed	mharbison72	D10311 contrib: restore the `hg fix` configuration in the examples
Closed	mharbison72	D10310 tests: restore the ability to run `black` on Windows
Closed	mharbison72	D10301 setup: copy python3.dll next to hg.exe when building on Windows for hgext.git
Closed	mharbison72	D10300 tests: stablize test-hook.t on Windows
Closed	mharbison72	D10299 tests: handle Windows file separator differences in test-config.t
Closed	mharbison72	D10298 tests: update the detailed exit codes for icasefs gated tests
Closed	mharbison72	D10297 tests: update the detailed exit codes in test-phabricator.t

Diff 26658

contrib/examples/fix.hgrc

	[fix]			[fix]
	clang-format:command = clang-format --style file			clang-format:command = clang-format --style file
	clang-format:pattern = set:(.c or .cc or **.h) and not "include:contrib/clang-format-ignorelist"			clang-format:pattern = set:(.c or .cc or **.h) and not "include:contrib/clang-format-ignorelist"

	rustfmt:command = rustfmt +nightly			rustfmt:command = rustfmt +nightly
	rustfmt:pattern = set:".rs" - "mercurial/thirdparty/"			rustfmt:pattern = set:".rs" - "mercurial/thirdparty/"

	black:command = black			black:command = black --config=pyproject.toml -
	black:pattern = set:.py - mercurial/thirdparty/			black:pattern = set:.py - mercurial/thirdparty/

	# Mercurial doesn't have any Go code, but if we did this is how we			# Mercurial doesn't have any Go code, but if we did this is how we
	# would configure `hg fix` for Go:			# would configure `hg fix` for Go:
	go:command = gofmt			go:command = gofmt
	go:pattern = set:**.go			go:pattern = set:**.go

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	26658		Apr 5 2021, 1:15 PM	★	★
Diff 2	26805	rHG3d32b97590476c2e7657b058788e61169a4059ca	Apr 5 2021, 1:02 PM	★	★