This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10396

test-lfs: avoid a bashism when spawning the server
ClosedPublic

Authored by marmoute on Apr 14 2021, 10:47 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG7a9b74e98240: test-lfs: avoid a bashism when spawning the server
Summary

For zsh, this &> call is read as "& >", this spin the process without
redirection. As a result the server grab stdout, which does not get closed at the
end of the test. As a result run-tests.py hang there forever, waiting for the
the stream for be close. (which is probably as issue on its own).

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Apr 14 2021, 10:47 AM
pulkit accepted this revision.Apr 14 2021, 7:51 PM
This revision is now accepted and ready to land.Apr 14 2021, 7:51 PM
marmoute added a commit: rHG7a9b74e98240: test-lfs: avoid a bashism when spawning the server.Apr 14 2021, 8:41 PM
Closed by commit rHG7a9b74e98240: test-lfs: avoid a bashism when spawning the server (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-lfs-test-server.t (4 lines)

Diff 26905

tests/test-lfs-test-server.t

$ LFS_HOST="localhost:$HGPORT" $ LFS_HOST="localhost:$HGPORT"
$ LFS_PUBLIC=1 $ LFS_PUBLIC=1
$ export LFS_LISTEN LFS_HOST LFS_PUBLIC $ export LFS_LISTEN LFS_HOST LFS_PUBLIC
#else #else
$ LFS_HOST="localhost:$HGPORT/.git/info/lfs" $ LFS_HOST="localhost:$HGPORT/.git/info/lfs"
#endif #endif
#if no-windows git-server #if no-windows git-server
$ lfs-test-server &> lfs-server.log & $ lfs-test-server > lfs-server.log 2>&1 &
$ echo $! >> $DAEMON_PIDS $ echo $! >> $DAEMON_PIDS
#endif #endif
#if windows git-server #if windows git-server
$ cat >> $TESTTMP/spawn.py <<EOF $ cat >> $TESTTMP/spawn.py <<EOF
> import os > import os
> import subprocess > import subprocess
> import sys > import sys
$LOCALIP - - [$LOGDATE$] "GET /.hg/lfs/objects/37a65ab78d5ecda767e8622c248b5dbff1e68b1678ab0e730d5eb8601ec8ad19 HTTP/1.1" 200 - (glob) $LOCALIP - - [$LOGDATE$] "GET /.hg/lfs/objects/37a65ab78d5ecda767e8622c248b5dbff1e68b1678ab0e730d5eb8601ec8ad19 HTTP/1.1" 200 - (glob)
$LOCALIP - - [$LOGDATE$] "GET /.hg/lfs/objects/d11e1a642b60813aee592094109b406089b8dff4cb157157f753418ec7857998 HTTP/1.1" 200 - (glob) $LOCALIP - - [$LOGDATE$] "GET /.hg/lfs/objects/d11e1a642b60813aee592094109b406089b8dff4cb157157f753418ec7857998 HTTP/1.1" 200 - (glob)
$LOCALIP - - [$LOGDATE$] "POST /.git/info/lfs/objects/batch HTTP/1.1" 200 - (glob) $LOCALIP - - [$LOGDATE$] "POST /.git/info/lfs/objects/batch HTTP/1.1" 200 - (glob)
#endif #endif
$ mkdir $TESTTMP/lfs-server2 $ mkdir $TESTTMP/lfs-server2
$ cd $TESTTMP/lfs-server2 $ cd $TESTTMP/lfs-server2
#if no-windows git-server #if no-windows git-server
$ lfs-test-server &> lfs-server.log & $ lfs-test-server > lfs-server.log 2>&1 &
$ echo $! >> $DAEMON_PIDS $ echo $! >> $DAEMON_PIDS
#endif #endif
#if windows git-server #if windows git-server
$ "$PYTHON" $TESTTMP/spawn.py >> $DAEMON_PIDS $ "$PYTHON" $TESTTMP/spawn.py >> $DAEMON_PIDS
#endif #endif
#if hg-server #if hg-server