This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10464

phab-refresh: use a special comment on the stable branch
ClosedPublic

Authored by marmoute on Apr 19 2021, 5:25 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG75351b8b2082: phab-refresh: use a special comment on the stable branch
rHGbf0cb00962e1: phab-refresh: use a special comment on the stable branch
Summary

Phabricator make it hard to spot the branch information. As a result patch
intended for stable are consistently queued for default.

We add a special command and flashy GIF to try to attract reviewer attention on
the fact patch are intended for stable.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.Apr 19 2021, 5:25 AM
marmoute planned changes to this revision.Apr 19 2021, 5:26 AM

let them refresh themselve to make sure things work.

baymax updated this revision to Diff 27044.Apr 19 2021, 7:23 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)
⚠ This patch is intended for stable ⚠

mharbison72 added a subscriber: mharbison72.Apr 19 2021, 11:44 PM

You might want to double check this because I think the phab extension has a bug related to importing non ascii characters in some cases, but the result looked OK.

marmoute added a commit: rHGbf0cb00962e1: phab-refresh: use a special comment on the stable branch.Apr 19 2021, 11:46 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHGbf0cb00962e1: phab-refresh: use a special comment on the stable branch (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcontrib/heptapod-ci.yml (8 lines)

Diff 27029

contrib/heptapod-ci.yml

<<: *rust_cargo_test <<: *rust_cargo_test
variables: variables:
PYTHON: python3 PYTHON: python3
phabricator-refresh: phabricator-refresh:
stage: phabricator stage: phabricator
variables: variables:
DEFAULT_COMMENT: ":white_check_mark: refresh by Heptapod after a successful CI run (:octopus: :green_heart:)" DEFAULT_COMMENT: ":white_check_mark: refresh by Heptapod after a successful CI run (:octopus: :green_heart:)"
STABLE_COMMENT: ":white_check_mark: refresh by Heptapod after a successful CI run (:octopus: :green_heart:)\n⚠ This patch is intended for stable ⚠\n{image https://media.giphy.com/media/nYI8SmmChYXK0/source.gif}"
script: script:
- "./contrib/phab-refresh-stack.sh --comment \"$DEFAULT_COMMENT\"" - |
if [ `hg branch` == "stable" ]; then
./contrib/phab-refresh-stack.sh --comment "$STABLE_COMMENT";
else
./contrib/phab-refresh-stack.sh --comment "$DEFAULT_COMMENT";
fi
test-py2: test-py2:
<<: *runtests <<: *runtests
variables: variables:
RUNTEST_ARGS: " --no-rust --blacklist /tmp/check-tests.txt" RUNTEST_ARGS: " --no-rust --blacklist /tmp/check-tests.txt"
TEST_HGMODULEPOLICY: "c" TEST_HGMODULEPOLICY: "c"
TEST_HGTESTS_ALLOW_NETIO: "1" TEST_HGTESTS_ALLOW_NETIO: "1"