This is an archive of the discontinued Mercurial Phabricator instance.

mail: split out the SMTP login to allow the keyring extension to wrap it
ClosedPublic

Authored by mharbison72 on Apr 19 2021, 7:40 PM.

Details

Summary

The keyring extension only needs to tweak this tiny section of the larger
function. But without any place to intercept the username/password fetching, it
copy/pasted the entire function, and has grown a bunch of compatibility hacks to
support older versions of Mercurial as well.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Apr 19 2021, 7:40 PM
marmoute accepted this revision.Apr 20 2021, 5:38 AM
This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.