This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10481

streamclone: treat volatile file as "fullfile"
ClosedPublic

Authored by marmoute on Apr 20 2021, 12:09 AM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHGaed6ceaad6d7: streamclone: treat volatile file as "fullfile"
Summary

The nodemap related file might change (or get deleted) during the stream clone
in a way incompatible with the streaming process.

So we introduce a new flag for this type of file and integrate it with the
existing revlog_type field recently added to store.walk returns.

We use that new flat to dispatch such file to the existing mechanism for "atomic
replacement" file for the nodemap docket and datafile. This fix the bugs we have
been adding tests for.

Strictly speaking, the nodemap datafile is happened only a could maybe be used
in a slightly more efficient way, however this is good enough for now.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Apr 20 2021, 12:09 AM
Alphare requested changes to this revision.Apr 20 2021, 4:45 AM
Alphare added a subscriber: Alphare.

Your description is mixing "append" and "happen" again, but in the reverse order of the last patch.

mercurial/store.py
392

s/as/is/

429

I think repeating a small comment here would be nice

This revision now requires changes to proceed.Apr 20 2021, 4:45 AM
marmoute added inline comments.Apr 20 2021, 4:55 AM
mercurial/store.py
392

I moved to files that are.

Thanks

baymax updated this revision to Diff 27090.Apr 20 2021, 5:20 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

Alphare accepted this revision.Apr 20 2021, 9:54 AM
marmoute added a commit: rHGaed6ceaad6d7: streamclone: treat volatile file as "fullfile".Apr 20 2021, 10:19 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHGaed6ceaad6d7: streamclone: treat volatile file as "fullfile" (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 27122

mercurial/store.py

b'00changelog.i', b'00changelog.i',
b'phaseroots', b'phaseroots',
b'obsstore', b'obsstore',
b'requires', b'requires',
] ]
REVLOG_FILES_MAIN_EXT = (b'.i', b'i.tmpcensored') REVLOG_FILES_MAIN_EXT = (b'.i', b'i.tmpcensored')
REVLOG_FILES_OTHER_EXT = (b'.d', b'.n', b'.nd', b'd.tmpcensored') REVLOG_FILES_OTHER_EXT = (b'.d', b'.n', b'.nd', b'd.tmpcensored')
# files that are "volatile" and might change between listing and streaming
AlphareUnsubmitted
Not Done

s/as/is/

Alphare: s/as/is/
marmouteAuthorUnsubmitted
Done

I moved to files that are.

Thanks

marmoute: I moved to `files that are`. Thanks
#
# note: the ".nd" file are nodemap data and won't "change" but they might be
# deleted.
REVLOG_FILES_VOLATILE_EXT = (b'.n', b'.nd')
def is_revlog(f, kind, st): def is_revlog(f, kind, st):
if kind != stat.S_IFREG: if kind != stat.S_IFREG:
return None return None
return revlog_type(f) return revlog_type(f)
def revlog_type(f): def revlog_type(f):
if f.endswith(REVLOG_FILES_MAIN_EXT): if f.endswith(REVLOG_FILES_MAIN_EXT):
return FILEFLAGS_REVLOG_MAIN return FILEFLAGS_REVLOG_MAIN
elif f.endswith(REVLOG_FILES_OTHER_EXT): elif f.endswith(REVLOG_FILES_OTHER_EXT):
return FILETYPE_FILELOG_OTHER t = FILETYPE_FILELOG_OTHER
if f.endswith(REVLOG_FILES_VOLATILE_EXT):
t |= FILEFLAGS_VOLATILE
return t
# the file is part of changelog data # the file is part of changelog data
FILEFLAGS_CHANGELOG = 1 << 13 FILEFLAGS_CHANGELOG = 1 << 13
# the file is part of manifest data # the file is part of manifest data
FILEFLAGS_MANIFESTLOG = 1 << 12 FILEFLAGS_MANIFESTLOG = 1 << 12
# the file is part of filelog data # the file is part of filelog data
FILEFLAGS_FILELOG = 1 << 11 FILEFLAGS_FILELOG = 1 << 11
# file that are not directly part of a revlog # file that are not directly part of a revlog
FILEFLAGS_OTHER = 1 << 10 FILEFLAGS_OTHER = 1 << 10
# the main entry point for a revlog # the main entry point for a revlog
FILEFLAGS_REVLOG_MAIN = 1 << 1 FILEFLAGS_REVLOG_MAIN = 1 << 1
# a secondary file for a revlog # a secondary file for a revlog
FILEFLAGS_REVLOG_OTHER = 1 << 0 FILEFLAGS_REVLOG_OTHER = 1 << 0
# files that are "volatile" and might change between listing and streaming
AlphareUnsubmitted
Not Done

I think repeating a small comment here would be nice

Alphare: I think repeating a small comment here would be nice
FILEFLAGS_VOLATILE = 1 << 20
FILETYPE_CHANGELOG_MAIN = FILEFLAGS_CHANGELOG | FILEFLAGS_REVLOG_MAIN FILETYPE_CHANGELOG_MAIN = FILEFLAGS_CHANGELOG | FILEFLAGS_REVLOG_MAIN
FILETYPE_CHANGELOG_OTHER = FILEFLAGS_CHANGELOG | FILEFLAGS_REVLOG_OTHER FILETYPE_CHANGELOG_OTHER = FILEFLAGS_CHANGELOG | FILEFLAGS_REVLOG_OTHER
FILETYPE_MANIFESTLOG_MAIN = FILEFLAGS_MANIFESTLOG | FILEFLAGS_REVLOG_MAIN FILETYPE_MANIFESTLOG_MAIN = FILEFLAGS_MANIFESTLOG | FILEFLAGS_REVLOG_MAIN
FILETYPE_MANIFESTLOG_OTHER = FILEFLAGS_MANIFESTLOG | FILEFLAGS_REVLOG_OTHER FILETYPE_MANIFESTLOG_OTHER = FILEFLAGS_MANIFESTLOG | FILEFLAGS_REVLOG_OTHER
FILETYPE_FILELOG_MAIN = FILEFLAGS_FILELOG | FILEFLAGS_REVLOG_MAIN FILETYPE_FILELOG_MAIN = FILEFLAGS_FILELOG | FILEFLAGS_REVLOG_MAIN
FILETYPE_FILELOG_OTHER = FILEFLAGS_FILELOG | FILEFLAGS_REVLOG_OTHER FILETYPE_FILELOG_OTHER = FILEFLAGS_FILELOG | FILEFLAGS_REVLOG_OTHER
FILETYPE_OTHER = FILEFLAGS_OTHER FILETYPE_OTHER = FILEFLAGS_OTHER

mercurial/streamclone.py

matcher = None matcher = None
if includes or excludes: if includes or excludes:
matcher = narrowspec.match(repo.root, includes, excludes) matcher = narrowspec.match(repo.root, includes, excludes)
repo.ui.debug(b'scanning\n') repo.ui.debug(b'scanning\n')
for rl_type, name, ename, size in _walkstreamfiles(repo, matcher): for rl_type, name, ename, size in _walkstreamfiles(repo, matcher):
if size: if size:
entries.append((_srcstore, name, _fileappend, size)) ft = _fileappend
if rl_type & store.FILEFLAGS_VOLATILE:
ft = _filefull
entries.append((_srcstore, name, ft, size))
totalfilesize += size totalfilesize += size
for name in _walkstreamfullstorefiles(repo): for name in _walkstreamfullstorefiles(repo):
if repo.svfs.exists(name): if repo.svfs.exists(name):
totalfilesize += repo.svfs.lstat(name).st_size totalfilesize += repo.svfs.lstat(name).st_size
entries.append((_srcstore, name, _filefull, None)) entries.append((_srcstore, name, _filefull, None))
if includeobsmarkers and repo.svfs.exists(b'obsstore'): if includeobsmarkers and repo.svfs.exists(b'obsstore'):
totalfilesize += repo.svfs.lstat(b'obsstore').st_size totalfilesize += repo.svfs.lstat(b'obsstore').st_size
entries.append((_srcstore, b'obsstore', _filefull, None)) entries.append((_srcstore, b'obsstore', _filefull, None))

tests/test-persistent-nodemap.t

Simple case Simple case
----------- -----------
No race condition No race condition
$ hg clone -U --stream --config ui.ssh="\"$PYTHON\" \"$TESTDIR/dummyssh\"" ssh://user@dummy/test-repo stream-clone --debug | egrep '00(changelog|manifest)' $ hg clone -U --stream --config ui.ssh="\"$PYTHON\" \"$TESTDIR/dummyssh\"" ssh://user@dummy/test-repo stream-clone --debug | egrep '00(changelog|manifest)'
adding [s] 00manifest.n (70 bytes) adding [s] 00manifest.n (70 bytes)
adding [s] 00manifest.d (452 KB) (no-zstd !)
adding [s] 00manifest.d (491 KB) (zstd !)
adding [s] 00manifest-*.nd (118 KB) (glob) adding [s] 00manifest-*.nd (118 KB) (glob)
adding [s] 00changelog.n (70 bytes) adding [s] 00changelog.n (70 bytes)
adding [s] 00changelog-*.nd (118 KB) (glob)
adding [s] 00manifest.d (452 KB) (no-zstd !)
adding [s] 00manifest.d (491 KB) (zstd !)
adding [s] 00changelog.d (360 KB) (no-zstd !) adding [s] 00changelog.d (360 KB) (no-zstd !)
adding [s] 00changelog.d (368 KB) (zstd !) adding [s] 00changelog.d (368 KB) (zstd !)
adding [s] 00changelog-*.nd (118 KB) (glob)
adding [s] 00manifest.i (313 KB) adding [s] 00manifest.i (313 KB)
adding [s] 00changelog.i (313 KB) adding [s] 00changelog.i (313 KB)
$ ls -1 stream-clone/.hg/store/ | egrep '00(changelog|manifest)(\.n|-.*\.nd)' $ ls -1 stream-clone/.hg/store/ | egrep '00(changelog|manifest)(\.n|-.*\.nd)'
00changelog-*.nd (glob) 00changelog-*.nd (glob)
00changelog.n 00changelog.n
00manifest-*.nd (glob) 00manifest-*.nd (glob)
00manifest.n 00manifest.n
$ hg -R stream-clone debugnodemap --metadata $ hg -R stream-clone debugnodemap --metadata
Do a mix of clone and commit at the same time so that the file listed on disk differ at actual transfer time. Do a mix of clone and commit at the same time so that the file listed on disk differ at actual transfer time.
$ (hg clone -U --stream --config ui.ssh="\"$PYTHON\" \"$TESTDIR/dummyssh\"" ssh://user@dummy/test-repo stream-clone-race-1 --debug 2>> clone-output | egrep '00(changelog|manifest)' >> clone-output; touch $HG_TEST_STREAM_WALKED_FILE_3) & $ (hg clone -U --stream --config ui.ssh="\"$PYTHON\" \"$TESTDIR/dummyssh\"" ssh://user@dummy/test-repo stream-clone-race-1 --debug 2>> clone-output | egrep '00(changelog|manifest)' >> clone-output; touch $HG_TEST_STREAM_WALKED_FILE_3) &
$ $RUNTESTDIR/testlib/wait-on-file 10 $HG_TEST_STREAM_WALKED_FILE_1 $ $RUNTESTDIR/testlib/wait-on-file 10 $HG_TEST_STREAM_WALKED_FILE_1
$ hg -R test-repo/ commit -m foo $ hg -R test-repo/ commit -m foo
$ touch $HG_TEST_STREAM_WALKED_FILE_2 $ touch $HG_TEST_STREAM_WALKED_FILE_2
$ $RUNTESTDIR/testlib/wait-on-file 10 $HG_TEST_STREAM_WALKED_FILE_3 $ $RUNTESTDIR/testlib/wait-on-file 10 $HG_TEST_STREAM_WALKED_FILE_3
$ cat clone-output $ cat clone-output
remote: abort: unexpected error: [Errno 2] $ENOENT$: *'$TESTTMP/test-repo/.hg/store/00manifest-*.nd' (glob) (known-bad-output no-rust no-pure !)
abort: pull failed on remote (known-bad-output no-rust no-pure !)
adding [s] 00manifest.n (70 bytes) adding [s] 00manifest.n (70 bytes)
adding [s] 00manifest.d (491 KB) (zstd !) adding [s] 00manifest-*.nd (118 KB) (glob)
adding [s] 00changelog.n (70 bytes)
adding [s] 00changelog-*.nd (118 KB) (glob)
adding [s] 00manifest.d (452 KB) (no-zstd !) adding [s] 00manifest.d (452 KB) (no-zstd !)
remote: abort: $ENOENT$: '$TESTTMP/test-repo/.hg/store/00manifest-*.nd' (glob) (known-bad-output no-rust no-pure !) adding [s] 00manifest.d (491 KB) (zstd !)
adding [s] 00manifest-*.nd (118 KB) (glob) (rust !)
adding [s] 00changelog.n (70 bytes) (rust !)
adding [s] 00changelog.d (368 KB) (zstd rust !)
adding [s] 00changelog-*.nd (118 KB) (glob) (rust !)
adding [s] 00manifest.i (313 KB) (rust !)
adding [s] 00changelog.i (313 KB) (rust !)
adding [s] 00manifest-*.nd (118 KB) (glob) (pure !)
adding [s] 00changelog.n (70 bytes) (pure !)
adding [s] 00changelog.d (360 KB) (no-zstd !) adding [s] 00changelog.d (360 KB) (no-zstd !)
adding [s] 00changelog-*.nd (118 KB) (glob) (pure !) adding [s] 00changelog.d (368 KB) (zstd !)
adding [s] 00manifest.i (313 KB) (pure !) adding [s] 00manifest.i (313 KB)
adding [s] 00changelog.i (313 KB) (pure !) adding [s] 00changelog.i (313 KB)
Check the result state Check the result state
$ f --size stream-clone-race-1/.hg/store/00changelog* $ f --size stream-clone-race-1/.hg/store/00changelog*
stream-clone-race-1/.hg/store/00changelog*: file not found (known-bad-output no-rust no-pure !) stream-clone-race-1/.hg/store/00changelog-*.nd: size=121088 (glob)
stream-clone-race-1/.hg/store/00changelog-*.nd: size=121088 (glob) (rust !) stream-clone-race-1/.hg/store/00changelog.d: size=368890 (no-zstd !)
stream-clone-race-1/.hg/store/00changelog.d: size=376891 (zstd rust !) stream-clone-race-1/.hg/store/00changelog.d: size=376891 (zstd !)
stream-clone-race-1/.hg/store/00changelog.i: size=320384 (rust !) stream-clone-race-1/.hg/store/00changelog.i: size=320384
stream-clone-race-1/.hg/store/00changelog.n: size=70 (rust !) stream-clone-race-1/.hg/store/00changelog.n: size=70
stream-clone-race-1/.hg/store/00changelog-*.nd: size=121088 (glob) (pure !)
stream-clone-race-1/.hg/store/00changelog.d: size=368890 (no-zstd pure !)
stream-clone-race-1/.hg/store/00changelog.i: size=320384 (pure !)
stream-clone-race-1/.hg/store/00changelog.n: size=70 (pure !)
$ hg -R stream-clone-race-1 debugnodemap --metadata | tee client-metadata.txt $ hg -R stream-clone-race-1 debugnodemap --metadata | tee client-metadata.txt
abort: repository stream-clone-race-1 not found (known-bad-output no-rust no-pure !) uid: * (glob)
uid: * (glob) (rust !) tip-rev: 5005
tip-rev: 5005 (rust !) tip-node: 90d5d3ba2fc47db50f712570487cb261a68c8ffe
tip-node: 90d5d3ba2fc47db50f712570487cb261a68c8ffe (rust !) data-length: 121088
data-length: 121088 (rust !) data-unused: 0
data-unused: 0 (rust !) data-unused: 0.000%
data-unused: 0.000% (rust !)
uid: * (glob) (pure !)
tip-rev: 5005 (pure !)
tip-node: 90d5d3ba2fc47db50f712570487cb261a68c8ffe (pure !)
data-length: 121088 (pure !)
data-unused: 0 (pure !)
data-unused: 0.000% (pure !)
We get a usable nodemap, so no rewrite would be needed and the metadata should be identical We get a usable nodemap, so no rewrite would be needed and the metadata should be identical
(ie: the following diff should be empty) (ie: the following diff should be empty)
This isn't the case for the `no-rust` `no-pure` implementation as it use a very minimal nodemap implementation that unconditionnaly rewrite the nodemap "all the time".
#if no-rust no-pure
$ diff -u server-metadata.txt client-metadata.txt $ diff -u server-metadata.txt client-metadata.txt
--- server-metadata.txt * (glob) (known-bad-output !) --- server-metadata.txt * (glob)
+++ client-metadata.txt * (glob) (known-bad-output !) +++ client-metadata.txt * (glob)
@@ -1,4 +1,4 @@ (known-bad-output rust !) @@ -1,4 +1,4 @@
@@ -1,4 +1,4 @@ (known-bad-output pure !) -uid: * (glob)
@@ -1,6 +0,0 @@ (known-bad-output no-rust no-pure !) +uid: * (glob)
-uid: * (glob) (known-bad-output !) tip-rev: 5005
+uid: * (glob) (known-bad-output rust !) tip-node: 90d5d3ba2fc47db50f712570487cb261a68c8ffe
tip-rev: 5005 (known-bad-output rust !) data-length: 121088
tip-node: 90d5d3ba2fc47db50f712570487cb261a68c8ffe (known-bad-output rust !)
data-length: 121088 (known-bad-output rust !)
+uid: * (glob) (known-bad-output pure !)
tip-rev: 5005 (known-bad-output pure !)
tip-node: 90d5d3ba2fc47db50f712570487cb261a68c8ffe (known-bad-output pure !)
data-length: 121088 (known-bad-output pure !)
-tip-rev: 5005 (known-bad-output no-rust no-pure !)
-tip-node: 90d5d3ba2fc47db50f712570487cb261a68c8ffe (known-bad-output no-rust no-pure !)
-data-length: 121088 (known-bad-output no-rust no-pure !)
-data-unused: 0 (known-bad-output no-rust no-pure !)
-data-unused: 0.000% (known-bad-output no-rust no-pure !)
[1] [1]
#else
$ diff -u server-metadata.txt client-metadata.txt
#endif
Clean up after the test. Clean up after the test.
$ rm -f "$HG_TEST_STREAM_WALKED_FILE_1" $ rm -f "$HG_TEST_STREAM_WALKED_FILE_1"
$ rm -f "$HG_TEST_STREAM_WALKED_FILE_2" $ rm -f "$HG_TEST_STREAM_WALKED_FILE_2"
$ rm -f "$HG_TEST_STREAM_WALKED_FILE_3" $ rm -f "$HG_TEST_STREAM_WALKED_FILE_3"
full regeneration full regeneration
test-repo/.hg/store/00changelog.d: size=368949 (no-zstd !) test-repo/.hg/store/00changelog.d: size=368949 (no-zstd !)
test-repo/.hg/store/00changelog.i: size=320448 test-repo/.hg/store/00changelog.i: size=320448
test-repo/.hg/store/00changelog.n: size=70 test-repo/.hg/store/00changelog.n: size=70
$ hg -R test-repo debugnodemap --metadata | tee server-metadata-2.txt $ hg -R test-repo debugnodemap --metadata | tee server-metadata-2.txt
uid: * (glob) uid: * (glob)
tip-rev: 5006 tip-rev: 5006
tip-node: ed2ec1eef9aa2a0ec5057c51483bc148d03e810b tip-node: ed2ec1eef9aa2a0ec5057c51483bc148d03e810b
data-length: 121344 (rust !) data-length: 121344 (rust !)
data-unused: 192 (rust !)
data-unused: 0.158% (rust !)
data-length: 121152 (no-rust no-pure !)
data-unused: 0 (no-rust no-pure !)
data-unused: 0.000% (no-rust no-pure !)
data-length: 121344 (pure !) data-length: 121344 (pure !)
data-length: 121152 (no-rust no-pure !)
data-unused: 192 (rust !)
data-unused: 192 (pure !) data-unused: 192 (pure !)
data-unused: 0 (no-rust no-pure !)
data-unused: 0.158% (rust !)
data-unused: 0.158% (pure !) data-unused: 0.158% (pure !)
data-unused: 0.000% (no-rust no-pure !)
Performe the mix of clone and full refresh of the nodemap, so that the files Performe the mix of clone and full refresh of the nodemap, so that the files
(and filenames) are different between listing time and actual transfer time. (and filenames) are different between listing time and actual transfer time.
$ (hg clone -U --stream --config ui.ssh="\"$PYTHON\" \"$TESTDIR/dummyssh\"" ssh://user@dummy/test-repo stream-clone-race-2 --debug 2>> clone-output-2 | egrep '00(changelog|manifest)' >> clone-output-2; touch $HG_TEST_STREAM_WALKED_FILE_3) & $ (hg clone -U --stream --config ui.ssh="\"$PYTHON\" \"$TESTDIR/dummyssh\"" ssh://user@dummy/test-repo stream-clone-race-2 --debug 2>> clone-output-2 | egrep '00(changelog|manifest)' >> clone-output-2; touch $HG_TEST_STREAM_WALKED_FILE_3) &
$ $RUNTESTDIR/testlib/wait-on-file 10 $HG_TEST_STREAM_WALKED_FILE_1 $ $RUNTESTDIR/testlib/wait-on-file 10 $HG_TEST_STREAM_WALKED_FILE_1
$ rm test-repo/.hg/store/00changelog.n $ rm test-repo/.hg/store/00changelog.n
$ rm test-repo/.hg/store/00changelog-*.nd $ rm test-repo/.hg/store/00changelog-*.nd
$ hg -R test-repo/ debugupdatecache $ hg -R test-repo/ debugupdatecache
$ touch $HG_TEST_STREAM_WALKED_FILE_2 $ touch $HG_TEST_STREAM_WALKED_FILE_2
$ $RUNTESTDIR/testlib/wait-on-file 10 $HG_TEST_STREAM_WALKED_FILE_3 $ $RUNTESTDIR/testlib/wait-on-file 10 $HG_TEST_STREAM_WALKED_FILE_3
$ cat clone-output-2 $ cat clone-output-2
remote: abort: unexpected error: [Errno 2] $ENOENT$: *'$TESTTMP/test-repo/.hg/store/00changelog-*.nd' (glob) (known-bad-output rust !)
remote: abort: unexpected error: [Errno 2] $ENOENT$: *'$TESTTMP/test-repo/.hg/store/00changelog-*.nd' (glob) (known-bad-output pure !)
remote: abort: unexpected error: [Errno 2] $ENOENT$: *'$TESTTMP/test-repo/.hg/store/00manifest-*.nd' (glob) (known-bad-output no-pure no-rust !)
abort: pull failed on remote (known-bad-output !)
adding [s] undo.backup.00manifest.n (70 bytes) (known-bad-output !) adding [s] undo.backup.00manifest.n (70 bytes) (known-bad-output !)
adding [s] undo.backup.00changelog.n (70 bytes) (known-bad-output !) adding [s] undo.backup.00changelog.n (70 bytes) (known-bad-output !)
adding [s] 00manifest.n (70 bytes) adding [s] 00manifest.n (70 bytes)
adding [s] 00manifest-*.nd (118 KB) (glob)
adding [s] 00changelog.n (70 bytes)
adding [s] 00changelog-*.nd (118 KB) (glob)
adding [s] 00manifest.d (492 KB) (zstd !) adding [s] 00manifest.d (492 KB) (zstd !)
adding [s] 00manifest.d (452 KB) (no-zstd !) adding [s] 00manifest.d (452 KB) (no-zstd !)
adding [s] 00manifest-*.nd (118 KB) (glob) (rust !)
adding [s] 00manifest-*.nd (118 KB) (glob) (pure !)
remote: abort: $ENOENT$: '$TESTTMP/test-repo/.hg/store/00changelog-*.nd' (glob) (known-bad-output rust !)
remote: abort: $ENOENT$: '$TESTTMP/test-repo/.hg/store/00manifest-*.nd' (glob) (known-bad-output no-pure no-rust !)
adding [s] 00changelog.n (70 bytes) (pure !)
adding [s] 00changelog.d (360 KB) (no-zstd !) adding [s] 00changelog.d (360 KB) (no-zstd !)
remote: abort: $ENOENT$: '$TESTTMP/test-repo/.hg/store/00changelog-*.nd' (glob) (known-bad-output pure !) adding [s] 00changelog.d (368 KB) (zstd !)
adding [s] 00manifest.i (313 KB)
adding [s] 00changelog.i (313 KB)
Check the result. Check the result.
$ f --size stream-clone-race-2/.hg/store/00changelog* $ f --size stream-clone-race-2/.hg/store/00changelog*
stream-clone-race-2/.hg/store/00changelog*: file not found (known-bad-output !) stream-clone-race-2/.hg/store/00changelog-*.nd: size=121344 (glob) (rust !)
stream-clone-race-2/.hg/store/00changelog-*.nd: size=121344 (glob) (pure !)
stream-clone-race-2/.hg/store/00changelog-*.nd: size=121152 (glob) (no-rust no-pure !)
stream-clone-race-2/.hg/store/00changelog.d: size=376950 (zstd !)
stream-clone-race-2/.hg/store/00changelog.d: size=368949 (no-zstd !)
stream-clone-race-2/.hg/store/00changelog.i: size=320448
stream-clone-race-2/.hg/store/00changelog.n: size=70
$ hg -R stream-clone-race-2 debugnodemap --metadata | tee client-metadata-2.txt $ hg -R stream-clone-race-2 debugnodemap --metadata | tee client-metadata-2.txt
abort: repository stream-clone-race-2 not found (known-bad-output !) uid: * (glob)
tip-rev: 5006
tip-node: ed2ec1eef9aa2a0ec5057c51483bc148d03e810b
data-length: 121344 (rust !)
data-unused: 192 (rust !)
data-unused: 0.158% (rust !)
data-length: 121152 (no-rust no-pure !)
data-unused: 0 (no-rust no-pure !)
data-unused: 0.000% (no-rust no-pure !)
data-length: 121344 (pure !)
data-unused: 192 (pure !)
data-unused: 0.158% (pure !)
We get a usable nodemap, so no rewrite would be needed and the metadata should be identical We get a usable nodemap, so no rewrite would be needed and the metadata should be identical
(ie: the following diff should be empty) (ie: the following diff should be empty)
This isn't the case for the `no-rust` `no-pure` implementation as it use a very minimal nodemap implementation that unconditionnaly rewrite the nodemap "all the time".
#if no-rust no-pure
$ diff -u server-metadata-2.txt client-metadata-2.txt $ diff -u server-metadata-2.txt client-metadata-2.txt
--- server-metadata-2.txt * (glob) (known-bad-output !) --- server-metadata-2.txt * (glob)
+++ client-metadata-2.txt * (glob) (known-bad-output !) +++ client-metadata-2.txt * (glob)
@@ -1,6 +0,0 @@ (known-bad-output !) @@ -1,4 +1,4 @@
-uid: * (glob) (known-bad-output !) -uid: * (glob)
-tip-rev: 5006 (known-bad-output !) +uid: * (glob)
-tip-node: ed2ec1eef9aa2a0ec5057c51483bc148d03e810b (known-bad-output !) tip-rev: 5006
-data-length: 121344 (known-bad-output rust !) tip-node: ed2ec1eef9aa2a0ec5057c51483bc148d03e810b
-data-unused: 192 (known-bad-output rust !) data-length: 121152
-data-unused: 0.158% (known-bad-output rust !)
-data-length: 121344 (known-bad-output pure !)
-data-unused: 192 (known-bad-output pure !)
-data-unused: 0.158% (known-bad-output pure !)
-data-length: 121152 (known-bad-output no-rust no-pure !)
-data-unused: 0 (known-bad-output no-rust no-pure !)
-data-unused: 0.000% (known-bad-output no-rust no-pure !)
[1] [1]
#else
$ diff -u server-metadata-2.txt client-metadata-2.txt
#endif
Clean up after the test Clean up after the test
$ rm -f $HG_TEST_STREAM_WALKED_FILE_1 $ rm -f $HG_TEST_STREAM_WALKED_FILE_1
$ rm -f $HG_TEST_STREAM_WALKED_FILE_2 $ rm -f $HG_TEST_STREAM_WALKED_FILE_2
$ rm -f $HG_TEST_STREAM_WALKED_FILE_3 $ rm -f $HG_TEST_STREAM_WALKED_FILE_3