This is an archive of the discontinued Mercurial Phabricator instance.

rust/hg-core/src/dirstate/status.rs
276	What CLI arguments are you thinking of? `--include` and `--exclude` for `hg status` affect the `matcher` but not which files are considered ignored v.s. unknown

Alphare added inline comments.May 3 2021, 6:19 AM

rust/hg-core/src/dirstate/status.rs
276	True, I was confused. :)

SimonSapin added a child revision: D10546: dirstate-tree: Give to `status()` mutable access to the `DirstateMap`.May 3 2021, 6:24 AM

Alphare accepted this revision.May 3 2021, 9:02 AM

This revision is now accepted and ready to land.May 3 2021, 9:02 AM

SimonSapin added a commit: rHG625da75d9413: rust: Add doc-comments to DirstateStatus fields.May 6 2021, 12:54 PM

Closed by commit rHG625da75d9413: rust: Add doc-comments to DirstateStatus fields (authored by SimonSapin). · Explain Why

This revision was automatically updated to reflect the committed changes.

SimonSapin added a commit: rHG623c8e4ddc6d: rust: Add doc-comments to DirstateStatus fields.May 6 2021, 3:42 PM

Your post is excellent, and it piqued my interest. It provides me with a wealth of important information, for which I am grateful. subway surfers shell shockers

Revision Contents
Changeset List

			Path	Packages
M			rust/hg-core/src/dirstate/status.rs (21 lines)

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	27115		Apr 20 2021, 10:18 AM	★	★
Diff 2	27145		Apr 20 2021, 1:03 PM	★	★
Diff 3	27655	rHG625da75d94139c27c261f9427ac3b5e8122fb614	Apr 6 2021, 9:49 AM	★	★

Commit	Parents	Author	Summary	Date
810c84eb040b	209827d7b740	Simon Sapin		Apr 6 2021, 9:49 AM

Status	Author	Revision
Abandoned	SimonSapin	D10366 rust: Refactor parse_dirstate() to take a callback
Closed	SimonSapin	D10560 dirstate-tree: Borrow paths from the "on disk" bytes
Closed	SimonSapin	D10559 dirstate-tree: Borrow copy source paths from the "on disk" bytes
Closed	SimonSapin	D10558 rust: Use `&HgPath` instead of `&HgPathBuf` in may APIs
Closed	SimonSapin	D10557 dirstate-tree: Make `DirstateMap` borrow from a bytes buffer
Closed	SimonSapin	D10556 rust: Read dirstate from disk in DirstateMap constructor
Closed	SimonSapin	D10555 rust: Remove handling of `parents` in `DirstateMap`
Closed	SimonSapin	D10554 dirstate-tree: Fold "tracked descendants" counter update in main walk
Closed	SimonSapin	D10553 dirstate-tree: Use HashMap instead of BTreeMap
Closed	SimonSapin	D10552 dirstate-tree: Add #[timed] attribute to `status` and `DirstateMap::read`
Closed	SimonSapin	D10551 dirstate-tree: Paralellize the status algorithm with Rayon
Closed	SimonSapin	D10550 dirstate-tree: Avoid BTreeMap double-lookup when inserting a dirstate entry
Closed	SimonSapin	D10549 dirstate-tree: Handle I/O errors in status
Closed	SimonSapin	D10548 dirstate-tree: Ignore FIFOs etc. in the status algorithm
Closed	SimonSapin	D10547 dirstate-tree: Add the new `status()` algorithm
Closed	SimonSapin	D10546 dirstate-tree: Give to `status()` mutable access to the `DirstateMap`
Closed	SimonSapin	D10495 rust: Add doc-comments to DirstateStatus fields
Closed	SimonSapin	D10494 rust: Move "lookup" a.k.a. "unsure" paths into `DirstateStatus` struct
Closed	SimonSapin	D10493 rust: Remove DirstateMap::file_fold_map
Closed	SimonSapin	D10492 dirstate-tree: Add "non normal" and "from other parent" sets
Closed	SimonSapin	D10491 dirstate-tree: Add add_file, remove_file, and drop_file
Closed	SimonSapin	D10490 dirstate-tree: Add has_dir and has_tracked_dir
Closed	SimonSapin	D10489 dirstate-tree: Add clear_ambiguous_times in the new DirstateMap
Closed	SimonSapin	D10488 dirstate-tree: Add copy_map_insert and copy_map_remove
Closed	SimonSapin	D10487 dirstate-tree: Maintain a counter of DirstateEntry’s and copy sources
Closed	SimonSapin	D10486 dirstate-tree: Serialize to disk
Closed	SimonSapin	D10485 rust: Add a Timestamp struct instead of abusing Duration
Closed	SimonSapin	D10370 dirstate-tree: Add tree traversal/iteration
Closed	SimonSapin	D10369 dirstate-tree: Add map `get` and `contains_key` methods
Closed	SimonSapin	D10368 dirstate-tree: Add parsing only dirstate parents from disk
Closed	SimonSapin	D10367 dirstate-tree: Implement DirstateMap::read
Closed	SimonSapin	D10365 dirstate-tree: Add `WithBasename` wrapper for `HgPath`
Closed	SimonSapin	D10364 dirstate-tree: Empty shell for a second Rust DirstateMap implementation
Closed	SimonSapin	D10363 dirstate-tree: Abstract "non-normal" and "other parent" sets
Closed	SimonSapin	D10362 dirstate-tree: Make Rust DirstateMap bindings go through a trait object

Diff 27115

rust/hg-core/src/dirstate/status.rs

	pub list_ignored: bool,			pub list_ignored: bool,
	/// Whether to collect traversed dirs for applying a callback later.			/// Whether to collect traversed dirs for applying a callback later.
	/// Used by `hg purge` for example.			/// Used by `hg purge` for example.
	pub collect_traversed_dirs: bool,			pub collect_traversed_dirs: bool,
	}			}

	#[derive(Debug)]			#[derive(Debug)]
	pub struct DirstateStatus<'a> {			pub struct DirstateStatus<'a> {
				/// Tracked files whose contents have changed since the parent revision
	pub modified: Vec<HgPathCow<'a>>,			pub modified: Vec<HgPathCow<'a>>,

				/// Newly-tracked files that were not present in the parent
	pub added: Vec<HgPathCow<'a>>,			pub added: Vec<HgPathCow<'a>>,

				/// Previously-tracked files that have been (re)moved with an hg command
	pub removed: Vec<HgPathCow<'a>>,			pub removed: Vec<HgPathCow<'a>>,

				/// (Still) tracked files that are missing, (re)moved with an non-hg
				/// command
	pub deleted: Vec<HgPathCow<'a>>,			pub deleted: Vec<HgPathCow<'a>>,

				/// Tracked files that are up to date with the parent.
				/// Only pupulated if `StatusOptions::list_clean` is true.
	pub clean: Vec<HgPathCow<'a>>,			pub clean: Vec<HgPathCow<'a>>,

				/// Files in the working directory that are ignored with `.hgignore`.
				AlphareUnsubmitted Not Done Or with an explicit pattern from the CLI Alphare: Or with an explicit pattern from the CLI
				SimonSapinAuthorUnsubmitted Done What CLI arguments are you thinking of? `--include` and `--exclude` for `hg status` affect the `matcher` but not which files are considered ignored v.s. unknown SimonSapin: What CLI arguments are you thinking of? `--include` and `--exclude` for `hg status` affect the…
				AlphareUnsubmitted Not Done True, I was confused. :) Alphare: True, I was confused. :)
				/// Only pupulated if `StatusOptions::list_ignored` is true.
	pub ignored: Vec<HgPathCow<'a>>,			pub ignored: Vec<HgPathCow<'a>>,

				/// Files in the working directory that are neither tracked nor ignored.
				/// Only pupulated if `StatusOptions::list_unknown` is true.
	pub unknown: Vec<HgPathCow<'a>>,			pub unknown: Vec<HgPathCow<'a>>,

				/// Was explicitly matched but cannot be found/accessed
	pub bad: Vec<(HgPathCow<'a>, BadMatch)>,			pub bad: Vec<(HgPathCow<'a>, BadMatch)>,

	/// Either clean or modified, but we can’t tell from filesystem metadata			/// Either clean or modified, but we can’t tell from filesystem metadata
	/// alone. The file contents need to be read and compared with that in			/// alone. The file contents need to be read and compared with that in
	/// the parent.			/// the parent.
	pub unsure: Vec<HgPathCow<'a>>,			pub unsure: Vec<HgPathCow<'a>>,

	/// Only filled if `collect_traversed_dirs` is `true`			/// Only filled if `collect_traversed_dirs` is `true`
	pub traversed: Vec<HgPathBuf>,			pub traversed: Vec<HgPathBuf>,
	}			}

	#[derive(Debug, derive_more::From)]			#[derive(Debug, derive_more::From)]
	pub enum StatusError {			pub enum StatusError {
	/// Generic IO error			/// Generic IO error
	IO(std::io::Error),			IO(std::io::Error),

This is an archive of the discontinued Mercurial Phabricator instance.

rust: Add doc-comments to DirstateStatus fieldsClosedPublic

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 27115

rust/hg-core/src/dirstate/status.rs

rust: Add doc-comments to DirstateStatus fields
ClosedPublic

Revision Contents
Changeset List