This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10505

mail: add a TODO about proper mbox locking
ClosedPublic

Authored by mharbison72 on Apr 20 2021, 11:31 PM.

Details

Reviewers
Alphare
pulkit
Group Reviewers
hg-reviewers
Commits
rHG106402245301: mail: add a TODO about proper mbox locking
Summary

Per @nbjoerg in IRC, the mbox isn't locked correctly.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Apr 20 2021, 11:31 PM
Alphare accepted this revision.Apr 21 2021, 8:18 AM
This revision is now accepted and ready to land.Apr 21 2021, 8:18 AM
pulkit accepted this revision.Apr 28 2021, 6:37 AM
mharbison72 added a commit: rHG106402245301: mail: add a TODO about proper mbox locking.Apr 28 2021, 11:09 AM
Closed by commit rHG106402245301: mail: add a TODO about proper mbox locking (authored by mharbison72). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/mail.py (1 line)

Diff 27185

mercurial/mail.py

os.path.basename(procutil.shellsplit(program)[0]), os.path.basename(procutil.shellsplit(program)[0]),
procutil.explainexit(ret), procutil.explainexit(ret),
) )
) )
def _mbox(mbox, sender, recipients, msg): def _mbox(mbox, sender, recipients, msg):
'''write mails to mbox''' '''write mails to mbox'''
# TODO: use python mbox library for proper locking
with open(mbox, b'ab+') as fp: with open(mbox, b'ab+') as fp:
# Should be time.asctime(), but Windows prints 2-characters day # Should be time.asctime(), but Windows prints 2-characters day
# of month instead of one. Make them print the same thing. # of month instead of one. Make them print the same thing.
date = time.strftime('%a %b %d %H:%M:%S %Y', time.localtime()) date = time.strftime('%a %b %d %H:%M:%S %Y', time.localtime())
fp.write( fp.write(
b'From %s %s\n' b'From %s %s\n'
% (encoding.strtolocal(sender), encoding.strtolocal(date)) % (encoding.strtolocal(sender), encoding.strtolocal(date))
) )