( )⚙ D10515 rewriteutil: add devel warning if precheck is called with contexts

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10515

rewriteutil: add devel warning if precheck is called with contexts
ClosedPublic

Authored by martinvonz on Apr 27 2021, 6:53 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG8ad2f43fe37b: rewriteutil: add devel warning if precheck is called with contexts
Summary

I'm trying to upstream parts from the evolve extension. This check
exists there.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mmercurial/rewriteutil.py (5 lines)

Diff 27245

mercurial/rewriteutil.py

) )
from . import ( from . import (
error, error,
obsolete, obsolete,
obsutil, obsutil,
revset, revset,
scmutil, scmutil,
util,
) )
NODE_RE = re.compile(br'\b[0-9a-f]{6,64}\b') NODE_RE = re.compile(br'\b[0-9a-f]{6,64}\b')
def precheck(repo, revs, action=b'rewrite'): def precheck(repo, revs, action=b'rewrite'):
"""check if revs can be rewritten """check if revs can be rewritten
action is used to control the error message. action is used to control the error message.
Make sure this function is called after taking the lock. Make sure this function is called after taking the lock.
""" """
if nullrev in revs: if nullrev in revs:
msg = _(b"cannot %s the null revision") % action msg = _(b"cannot %s the null revision") % action
hint = _(b"no changeset checked out") hint = _(b"no changeset checked out")
raise error.InputError(msg, hint=hint) raise error.InputError(msg, hint=hint)
if any(util.safehasattr(r, 'rev') for r in revs):
repo.ui.develwarn(b"rewriteutil.precheck called with ctx not revs")
revs = (r.rev() for r in revs)
if len(repo[None].parents()) > 1: if len(repo[None].parents()) > 1:
raise error.StateError(_(b"cannot %s while merging") % action) raise error.StateError(_(b"cannot %s while merging") % action)
publicrevs = repo.revs(b'%ld and public()', revs) publicrevs = repo.revs(b'%ld and public()', revs)
if publicrevs: if publicrevs:
msg = _(b"cannot %s public changesets") % action msg = _(b"cannot %s public changesets") % action
hint = _(b"see 'hg help phases' for details") hint = _(b"see 'hg help phases' for details")
raise error.InputError(msg, hint=hint) raise error.InputError(msg, hint=hint)