Page MenuHomePhabricator

manifests: push down expected node length into the parser
ClosedPublic

Authored by joerg.sonnenberger on Apr 29 2021, 8:13 PM.

Details

Summary

This strictly enforces the node length in the manifest lines according
to what the repository expects. One test case moves large hash testing
into the non-treemanifest part as treemanifests don't provide an
interface for overriding just the node length for now.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Alphare accepted this revision.May 3 2021, 7:55 AM
This revision is now accepted and ready to land.May 3 2021, 7:55 AM

This looks overall sane, but the size of the patch make it hard to be 100% confided nothing fishy sneaked in. I guess this is what testing is for…