This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10534

tests: bump default timeout to 360s
ClosedPublic

Authored by joerg.sonnenberger on Apr 29 2021, 8:25 PM.

Details

Reviewers
Alphare
marmoute
Group Reviewers
hg-reviewers
Commits
rHGc853bc60c5d6: tests: bump default timeout to 360s
Summary

A number of tests hit or almost hit the default limit even on modern
hardware. While the tests are ideally split into smaller pieces, that's
non-trivial work. HyperThreading and similar technologies can trigger
this often, even without any other load on the machine.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Alphare accepted this revision.May 3 2021, 7:56 AM
This revision is now accepted and ready to land.May 3 2021, 7:56 AM
marmoute accepted this revision.May 3 2021, 8:44 AM
marmoute added a subscriber: marmoute.

I configured such timeout in my system… so +1

joerg.sonnenberger added a commit: rHGc853bc60c5d6: tests: bump default timeout to 360s.May 3 2021, 8:48 AM
Closed by commit rHGc853bc60c5d6: tests: bump default timeout to 360s (authored by joerg.sonnenberger). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/run-tests.py (2 lines)

Diff 27410

tests/run-tests.py

PYTHON = _sys2bytes(sysexecutable.replace('\\', '/')) PYTHON = _sys2bytes(sysexecutable.replace('\\', '/'))
IMPL_PATH = b'PYTHONPATH' IMPL_PATH = b'PYTHONPATH'
if 'java' in sys.platform: if 'java' in sys.platform:
IMPL_PATH = b'JYTHONPATH' IMPL_PATH = b'JYTHONPATH'
default_defaults = { default_defaults = {
'jobs': ('HGTEST_JOBS', multiprocessing.cpu_count()), 'jobs': ('HGTEST_JOBS', multiprocessing.cpu_count()),
'timeout': ('HGTEST_TIMEOUT', 180), 'timeout': ('HGTEST_TIMEOUT', 360),
'slowtimeout': ('HGTEST_SLOWTIMEOUT', 1500), 'slowtimeout': ('HGTEST_SLOWTIMEOUT', 1500),
'port': ('HGTEST_PORT', 20059), 'port': ('HGTEST_PORT', 20059),
'shell': ('HGTEST_SHELL', 'sh'), 'shell': ('HGTEST_SHELL', 'sh'),
} }
defaults = default_defaults.copy() defaults = default_defaults.copy()