This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10541

phabricator: adapt to the new `urlutil.url()` API
ClosedPublic

Authored by mharbison72 on May 1 2021, 1:51 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG067f2c53fb24: phabricator: adapt to the new `urlutil.url()` API
Summary

This avoids a bunch of deprecation warnings in the tests.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.May 1 2021, 1:51 AM
pulkit accepted this revision.May 3 2021, 5:48 AM
This revision is now accepted and ready to land.May 3 2021, 5:48 AM
mharbison72 added a commit: rHG067f2c53fb24: phabricator: adapt to the new `urlutil.url()` API.May 3 2021, 10:07 AM
Closed by commit rHG067f2c53fb24: phabricator: adapt to the new `urlutil.url()` API (authored by mharbison72). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/phabricator.py (2 lines)

Diff 27440

hgext/phabricator.py

) )
return url, token return url, token
def callconduit(ui, name, params): def callconduit(ui, name, params):
"""call Conduit API, params is a dict. return json.loads result, or None""" """call Conduit API, params is a dict. return json.loads result, or None"""
host, token = readurltoken(ui) host, token = readurltoken(ui)
url, authinfo = util.url(b'/'.join([host, b'api', name])).authinfo() url, authinfo = urlutil.url(b'/'.join([host, b'api', name])).authinfo()
ui.debug(b'Conduit Call: %s %s\n' % (url, pycompat.byterepr(params))) ui.debug(b'Conduit Call: %s %s\n' % (url, pycompat.byterepr(params)))
params = params.copy() params = params.copy()
params[b'__conduit__'] = { params[b'__conduit__'] = {
b'token': token, b'token': token,
} }
rawdata = { rawdata = {
b'params': templatefilters.json(params), b'params': templatefilters.json(params),
b'output': b'json', b'output': b'json',