This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1069

bitmanipulation: reformat with clang-format
ClosedPublic

Authored by durin42 on Oct 14 2017, 3:05 AM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHGce77b0563228: bitmanipulation: reformat with clang-format
Summary

Mostly un-wrapping over-wrapped definitions.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Oct 14 2017, 3:05 AM
abuehl added a subscriber: abuehl.Oct 14 2017, 3:32 AM
abuehl added inline comments.
mercurial/bitmanipulation.h
34

this one looks bad

durin42 marked an inline comment as done.Oct 14 2017, 4:15 PM
durin42 added inline comments.
mercurial/bitmanipulation.h
34

Won't fix: the point of clang-format is that if we want to change how things are formatted, we should do so by adjusting the formatter config, not by hand-tuning things.

(Presumably there's a way to change the spelling of this line to format better, or else to tweak clang-format config, but that's not the goal of this patch series.)

indygreg accepted this revision.Oct 14 2017, 4:37 PM
This revision is now accepted and ready to land.Oct 14 2017, 4:37 PM
durin42 marked an inline comment as done.Oct 14 2017, 4:41 PM
Closed by commit rHGce77b0563228: bitmanipulation: reformat with clang-format (authored by durin42). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/bitmanipulation.h (15 lines)

Diff 2746

mercurial/bitmanipulation.h

#ifndef _HG_BITMANIPULATION_H_ #ifndef _HG_BITMANIPULATION_H_
#define _HG_BITMANIPULATION_H_ #define _HG_BITMANIPULATION_H_
#include <string.h> #include <string.h>
#include "compat.h" #include "compat.h"
static inline uint32_t getbe32(const char *c) static inline uint32_t getbe32(const char *c)
{ {
const unsigned char *d = (const unsigned char *)c; const unsigned char *d = (const unsigned char *)c;
return ((d[0] << 24) | return ((d[0] << 24) | (d[1] << 16) | (d[2] << 8) | (d[3]));
(d[1] << 16) |
(d[2] << 8) |
(d[3]));
} }
static inline int16_t getbeint16(const char *c) static inline int16_t getbeint16(const char *c)
{ {
const unsigned char *d = (const unsigned char *)c; const unsigned char *d = (const unsigned char *)c;
return ((d[0] << 8) | return ((d[0] << 8) | (d[1]));
(d[1]));
} }
static inline uint16_t getbeuint16(const char *c) static inline uint16_t getbeuint16(const char *c)
{ {
const unsigned char *d = (const unsigned char *)c; const unsigned char *d = (const unsigned char *)c;
return ((d[0] << 8) | return ((d[0] << 8) | (d[1]));
(d[1]));
} }
static inline void putbe32(uint32_t x, char *c) static inline void putbe32(uint32_t x, char *c)
{ {
c[0] = (x >> 24) & 0xff; c[0] = (x >> 24) & 0xff;
c[1] = (x >> 16) & 0xff; c[1] = (x >> 16) & 0xff;
c[2] = (x >> 8) & 0xff; c[2] = (x >> 8) & 0xff;
c[3] = (x) & 0xff; c[3] = (x)&0xff;
abuehlUnsubmitted
Done

this one looks bad

abuehl: this one looks bad
durin42AuthorUnsubmitted
Not Done

Won't fix: the point of clang-format is that if we want to change how things are formatted, we should do so by adjusting the formatter config, not by hand-tuning things.

(Presumably there's a way to change the spelling of this line to format better, or else to tweak clang-format config, but that's not the goal of this patch series.)

durin42: Won't fix: the point of clang-format is that if we want to change how things are formatted, we…
} }
static inline double getbefloat64(const char *c) static inline double getbefloat64(const char *c)
{ {
const unsigned char *d = (const unsigned char *)c; const unsigned char *d = (const unsigned char *)c;
double ret; double ret;
int i; int i;
uint64_t t = 0; uint64_t t = 0;
for (i = 0; i < 8; i++) { for (i = 0; i < 8; i++) {
t = (t<<8) + d[i]; t = (t << 8) + d[i];
} }
memcpy(&ret, &t, sizeof(t)); memcpy(&ret, &t, sizeof(t));
return ret; return ret;
} }
#endif #endif