( )⚙ D10694 hghave: fix the definition of `python3` to work on Windows

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10694

hghave: fix the definition of `python3` to work on Windows
ClosedPublic

Authored by mharbison72 on May 7 2021, 12:01 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG94c0c36299b1: hghave: fix the definition of `python3` to work on Windows
Summary

Both py2 and py3 executables are named python.exe, and may or may not be on
PATH. So use the dispatcher executable that comes with py3 to fetch the version
of the latest py3 executable. This allows at least one relnotes test to run on
Windows.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.May 7 2021, 12:01 AM
mharbison72 added a commit: rHG94c0c36299b1: hghave: fix the definition of `python3` to work on Windows.May 14 2021, 3:09 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG94c0c36299b1: hghave: fix the definition of `python3` to work on Windows (authored by mharbison72). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/hghave.py (5 lines)

Diff 27915

tests/hghave.py

@check("py3", "running with Python 3.x") @check("py3", "running with Python 3.x")
def has_py3(): def has_py3():
return 3 == sys.version_info[0] return 3 == sys.version_info[0]
@check("py3exe", "a Python 3.x interpreter is available") @check("py3exe", "a Python 3.x interpreter is available")
def has_python3exe(): def has_python3exe():
return matchoutput('python3 -V', br'^Python 3.(5|6|7|8|9)') py = 'python3'
if os.name == 'nt':
py = 'py -3'
return matchoutput('%s -V' % py, br'^Python 3.(5|6|7|8|9)')
@check("pure", "running with pure Python code") @check("pure", "running with pure Python code")
def has_pure(): def has_pure():
return any( return any(
[ [
os.environ.get("HGMODULEPOLICY") == "py", os.environ.get("HGMODULEPOLICY") == "py",
os.environ.get("HGTEST_RUN_TESTS_PURE") == "--pure", os.environ.get("HGTEST_RUN_TESTS_PURE") == "--pure",