This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10692

run-tests: ignore PermissionError when checking available ports
ClosedPublic

Authored by mharbison72 on May 7 2021, 12:01 AM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Summary

I'm not sure what this is, but I'm getting it occasionally when running in WSL.
When it was raised, none of the tests could run.

Diff Detail

Repository
rHG Mercurial
Branch
stable
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

mharbison72 created this revision.May 7 2021, 12:01 AM
Alphare accepted this revision.May 17 2021, 3:54 AM
This revision is now accepted and ready to land.May 17 2021, 3:54 AM
durin42 added a subscriber: durin42.May 19 2021, 1:39 PM

This looks good to me too, but needs rebased.

mharbison72 closed this revision.Jul 9 2021, 11:25 AM

This landed as 6e0af81c43b2, but lacked the Differential URL in the commit comment somehow. It may have gotten pulled off of the Windows CI work on heptapod.

Revision Contents
Changeset List

PathPackages
Mtests/run-tests.py (8 lines)
Mtests/test-check-pyflakes.t (1 line)

Diff 27737

tests/run-tests.py

family = socket.AF_INET family = socket.AF_INET
try: try:
with contextlib.closing(socket.socket(family, socket.SOCK_STREAM)) as s: with contextlib.closing(socket.socket(family, socket.SOCK_STREAM)) as s:
s.bind(('localhost', port)) s.bind(('localhost', port))
return True return True
except socket.error as exc: except socket.error as exc:
if os.name == 'nt' and exc.errno == errno.WSAEACCES: if os.name == 'nt' and exc.errno == errno.WSAEACCES:
return False return False
elif exc.errno not in ( elif PYTHON3:
# TODO: make a proper exception handler after dropping py2. This
# works because socket.error is an alias for OSError on py3,
# which is also the baseclass of PermissionError.
if isinstance(exc, PermissionError):
return False
if exc.errno not in (
errno.EADDRINUSE, errno.EADDRINUSE,
errno.EADDRNOTAVAIL, errno.EADDRNOTAVAIL,
errno.EPROTONOSUPPORT, errno.EPROTONOSUPPORT,
): ):
raise raise
return False return False

tests/test-check-pyflakes.t

> -X mercurial/pycompat.py -X contrib/python-zstandard \ > -X mercurial/pycompat.py -X contrib/python-zstandard \
> -X mercurial/thirdparty \ > -X mercurial/thirdparty \
> 2>/dev/null \ > 2>/dev/null \
> | xargs "$PYTHON" -m pyflakes 2>/dev/null | "$TESTDIR/filterpyflakes.py" > | xargs "$PYTHON" -m pyflakes 2>/dev/null | "$TESTDIR/filterpyflakes.py"
contrib/perf.py:*:* undefined name 'xrange' (glob) (?) contrib/perf.py:*:* undefined name 'xrange' (glob) (?)
mercurial/hgweb/server.py:*:* undefined name 'reload' (glob) (?) mercurial/hgweb/server.py:*:* undefined name 'reload' (glob) (?)
mercurial/util.py:*:* undefined name 'file' (glob) (?) mercurial/util.py:*:* undefined name 'file' (glob) (?)
mercurial/encoding.py:*:* undefined name 'localstr' (glob) (?) mercurial/encoding.py:*:* undefined name 'localstr' (glob) (?)
tests/run-tests.py:*:* undefined name 'PermissionError' (glob) (?)