This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10733

hghave: make error output easier to diagnose
ClosedPublic

Authored by durin42 on May 18 2021, 1:55 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG338623a2ebf2: hghave: make error output easier to diagnose
Summary

I had a typo that meant the new bash check was throwing an exception
(due to a missing argument), but it was very hard to diagnose without
this change.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.May 18 2021, 1:55 PM
pulkit accepted this revision.May 20 2021, 4:50 AM
This revision is now accepted and ready to land.May 20 2021, 4:50 AM
durin42 added a commit: rHG338623a2ebf2: hghave: make error output easier to diagnose.May 20 2021, 9:23 AM
Closed by commit rHG338623a2ebf2: hghave: make error output easier to diagnose (authored by durin42). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/hghave.py (4 lines)

Diff 28153

tests/hghave.py

if feature not in checks: if feature not in checks:
result['missing'].append(feature) result['missing'].append(feature)
continue continue
check, desc = checks[feature] check, desc = checks[feature]
try: try:
available = check() available = check()
except Exception: except Exception as e:
result['error'].append('hghave check failed: %s' % feature) result['error'].append('hghave check %s failed: %r' % (feature, e))
continue continue
if not negate and not available: if not negate and not available:
result['skipped'].append('missing feature: %s' % desc) result['skipped'].append('missing feature: %s' % desc)
elif negate and available: elif negate and available:
result['skipped'].append('system supports %s' % desc) result['skipped'].append('system supports %s' % desc)
return result return result