( )⚙ D10759 tests: monkeypatch `util.get_password()` to avoid deadlocks on Windows

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10759

tests: monkeypatch `util.get_password()` to avoid deadlocks on Windows
ClosedPublic

Authored by mharbison72 on May 20 2021, 3:41 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG5ac0f2a8ba72: tests: monkeypatch `util.get_password()` to avoid deadlocks on Windows
Summary

This should have been part of 5b3513177f2b.

Diff Detail

Repository
rHG Mercurial
Branch
stable
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

mharbison72 created this revision.May 20 2021, 3:41 PM
pulkit accepted this revision.May 23 2021, 3:35 PM
This revision is now accepted and ready to land.May 23 2021, 3:35 PM

Revision Contents
Changeset List

Diff 28162

tests/test-http-bundle1.t

$ cd test $ cd test
$ hg serve --config extensions.x=$TESTDIR/httpserverauth.py -p $HGPORT2 -d \ $ hg serve --config extensions.x=$TESTDIR/httpserverauth.py -p $HGPORT2 -d \
> --pid-file=pid --config server.preferuncompressed=True \ > --pid-file=pid --config server.preferuncompressed=True \
> --config web.push_ssl=False --config web.allow_push=* -A ../access.log > --config web.push_ssl=False --config web.allow_push=* -A ../access.log
$ cat pid >> $DAEMON_PIDS $ cat pid >> $DAEMON_PIDS
$ cat << EOF > get_pass.py $ cat << EOF > get_pass.py
> import getpass > from mercurial import util
> def newgetpass(arg): > def newgetpass():
> return "pass" > return "pass"
> getpass.getpass = newgetpass > util.get_password = newgetpass
> EOF > EOF
$ hg id http://localhost:$HGPORT2/ $ hg id http://localhost:$HGPORT2/
abort: http authorization required for http://localhost:$HGPORT2/ abort: http authorization required for http://localhost:$HGPORT2/
[255] [255]
$ hg id http://localhost:$HGPORT2/ $ hg id http://localhost:$HGPORT2/
abort: http authorization required for http://localhost:$HGPORT2/ abort: http authorization required for http://localhost:$HGPORT2/
[255] [255]

tests/test-http.t

$ cd test $ cd test
$ hg serve --config extensions.x=$TESTDIR/httpserverauth.py -p $HGPORT2 -d \ $ hg serve --config extensions.x=$TESTDIR/httpserverauth.py -p $HGPORT2 -d \
> --pid-file=pid --config server.preferuncompressed=True -E ../errors2.log \ > --pid-file=pid --config server.preferuncompressed=True -E ../errors2.log \
> --config web.push_ssl=False --config web.allow_push=* -A ../access.log > --config web.push_ssl=False --config web.allow_push=* -A ../access.log
$ cat pid >> $DAEMON_PIDS $ cat pid >> $DAEMON_PIDS
$ cat << EOF > get_pass.py $ cat << EOF > get_pass.py
> import getpass > from mercurial import util
> def newgetpass(arg): > def newgetpass():
> return "pass" > return "pass"
> getpass.getpass = newgetpass > util.get_password = newgetpass
> EOF > EOF
$ hg id http://localhost:$HGPORT2/ $ hg id http://localhost:$HGPORT2/
abort: http authorization required for http://localhost:$HGPORT2/ abort: http authorization required for http://localhost:$HGPORT2/
[255] [255]
$ hg id http://localhost:$HGPORT2/ $ hg id http://localhost:$HGPORT2/
abort: http authorization required for http://localhost:$HGPORT2/ abort: http authorization required for http://localhost:$HGPORT2/
[255] [255]

tests/test-largefiles-wireproto.t

$ rm "${USERCACHE}"/* $ rm "${USERCACHE}"/*
$ cd .. $ cd ..
$ hg serve --config extensions.x=$TESTDIR/httpserverauth.py -R credentialmain \ $ hg serve --config extensions.x=$TESTDIR/httpserverauth.py -R credentialmain \
> -d -p $HGPORT --pid-file hg.pid -A access.log > -d -p $HGPORT --pid-file hg.pid -A access.log
$ cat hg.pid >> $DAEMON_PIDS $ cat hg.pid >> $DAEMON_PIDS
$ cat << EOF > get_pass.py $ cat << EOF > get_pass.py
> import getpass > from mercurial import util
> def newgetpass(arg): > def newgetpass():
> return "pass" > return "pass"
> getpass.getpass = newgetpass > util.get_password = newgetpass
> EOF > EOF
$ hg clone --config ui.interactive=true --config extensions.getpass=get_pass.py \ $ hg clone --config ui.interactive=true --config extensions.getpass=get_pass.py \
> http://user@localhost:$HGPORT credentialclone > http://user@localhost:$HGPORT credentialclone
http authorization required for http://localhost:$HGPORT/ http authorization required for http://localhost:$HGPORT/
realm: mercurial realm: mercurial
user: user user: user
password: requesting all changes password: requesting all changes
adding changesets adding changesets