This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10760

run-tests: enable color on Windows
ClosedPublic

Authored by mharbison72 on May 20 2021, 4:16 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGbb4606f35d37: run-tests: enable color on Windows
Summary

In setting up the CI for Windows on heptapod, I noticed it was complaining about
color not being enabled because pygments wasn't installed- even though it was.
I had initially disabled color on Windows when using Windows 7, because that
didn't understand ANSI color codes and made a mess of the output. But now that
it's been unsupported for over a year, I don't think we should care about it
either.

It's admittedly a hack to depend on Mercurial proper to enable color support in
the terminal, but I didn't feel like duplicating that code. I'm under the
impression that 3rd party stuff is supposed to use this runner in the Mercurial
repo instead of using their own copy, so I think it's safe to assume the
Mercurial code is available. If it's not, it won't break anything.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

mharbison72 created this revision.May 20 2021, 4:16 PM
pulkit accepted this revision.May 23 2021, 3:34 PM
This revision is now accepted and ready to land.May 23 2021, 3:34 PM
mharbison72 added a commit: rHGbb4606f35d37: run-tests: enable color on Windows.May 23 2021, 6:05 PM
Closed by commit rHGbb4606f35d37: run-tests: enable color on Windows (authored by mharbison72). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/run-tests.py (40 lines)

Diff 28163

tests/run-tests.py

except (ImportError, AttributeError): except (ImportError, AttributeError):
import pipes import pipes
shellquote = pipes.quote shellquote = pipes.quote
processlock = threading.Lock() processlock = threading.Lock()
pygmentspresent = False pygmentspresent = False
# ANSI color is unsupported prior to Windows 10
if os.name != 'nt':
try: # is pygments installed try: # is pygments installed
import pygments import pygments
import pygments.lexers as lexers import pygments.lexers as lexers
import pygments.lexer as lexer import pygments.lexer as lexer
import pygments.formatters as formatters import pygments.formatters as formatters
import pygments.token as token import pygments.token as token
import pygments.style as style import pygments.style as style
if os.name == 'nt':
hgpath = os.path.dirname(os.path.dirname(os.path.abspath(__file__)))
sys.path.append(hgpath)
try:
from mercurial import win32 # pytype: disable=import-error
# Don't check the result code because it fails on heptapod, but
# something is able to convert to color anyway.
win32.enablevtmode()
finally:
sys.path = sys.path[:-1]
pygmentspresent = True pygmentspresent = True
difflexer = lexers.DiffLexer() difflexer = lexers.DiffLexer()
terminal256formatter = formatters.Terminal256Formatter() terminal256formatter = formatters.Terminal256Formatter()
except ImportError: except ImportError:
pass pass
if pygmentspresent: if pygmentspresent:
class TestRunnerStyle(style.Style): class TestRunnerStyle(style.Style):
default_style = "" default_style = ""
skipped = token.string_to_tokentype("Token.Generic.Skipped") skipped = token.string_to_tokentype("Token.Generic.Skipped")
failed = token.string_to_tokentype("Token.Generic.Failed") failed = token.string_to_tokentype("Token.Generic.Failed")
skippedname = token.string_to_tokentype("Token.Generic.SName") skippedname = token.string_to_tokentype("Token.Generic.SName")