Page MenuHomePhabricator

run-tests: enable color on Windows
ClosedPublic

Authored by mharbison72 on May 20 2021, 4:16 PM.

Details

Summary

In setting up the CI for Windows on heptapod, I noticed it was complaining about
color not being enabled because pygments wasn't installed- even though it was.
I had initially disabled color on Windows when using Windows 7, because that
didn't understand ANSI color codes and made a mess of the output. But now that
it's been unsupported for over a year, I don't think we should care about it
either.

It's admittedly a hack to depend on Mercurial proper to enable color support in
the terminal, but I didn't feel like duplicating that code. I'm under the
impression that 3rd party stuff is supposed to use this runner in the Mercurial
repo instead of using their own copy, so I think it's safe to assume the
Mercurial code is available. If it's not, it won't break anything.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

mharbison72 created this revision.May 20 2021, 4:16 PM
pulkit accepted this revision.May 23 2021, 3:34 PM
This revision is now accepted and ready to land.May 23 2021, 3:34 PM
This revision was automatically updated to reflect the committed changes.