( )⚙ D10773 revlogv2: simplify and clarify the processing of each entry

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10773

revlogv2: simplify and clarify the processing of each entry
ClosedPublic

Authored by marmoute on May 27 2021, 3:05 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGf286d715f9ab: revlogv2: simplify and clarify the processing of each entry
rHG3f218413696d: revlogv2: simplify and clarify the processing of each entry
Summary

As we add more entries and some of them has non trivial processing it seems
useful to make the processing leaner and clearly separated to simplify futures
patches.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mmercurial/revlogutils/docket.py (27 lines)

Diff 28224

mercurial/revlogutils/docket.py

docket._dirty = True docket._dirty = True
return docket return docket
def parse_docket(revlog, data, use_pending=False): def parse_docket(revlog, data, use_pending=False):
"""given some docket data return a docket object for the given revlog""" """given some docket data return a docket object for the given revlog"""
header = S_HEADER.unpack(data[: S_HEADER.size]) header = S_HEADER.unpack(data[: S_HEADER.size])
offset = S_HEADER.size offset = S_HEADER.size
version_header = header[0]
index_uuid_size = header[1] iheader = iter(header)
version_header = next(iheader)
index_uuid_size = next(iheader)
index_uuid = data[offset : offset + index_uuid_size] index_uuid = data[offset : offset + index_uuid_size]
offset += index_uuid_size offset += index_uuid_size
data_uuid_size = header[2]
data_uuid_size = next(iheader)
data_uuid = data[offset : offset + data_uuid_size] data_uuid = data[offset : offset + data_uuid_size]
offset += data_uuid_size offset += data_uuid_size
index_size = header[3]
pending_index_size = header[4] index_size = next(iheader)
data_size = header[5]
pending_data_size = header[6] pending_index_size = next(iheader)
default_compression_header = header[7]
data_size = next(iheader)
pending_data_size = next(iheader)
default_compression_header = next(iheader)
docket = RevlogDocket( docket = RevlogDocket(
revlog, revlog,
use_pending=use_pending, use_pending=use_pending,
version_header=version_header, version_header=version_header,
index_uuid=index_uuid, index_uuid=index_uuid,
data_uuid=data_uuid, data_uuid=data_uuid,
index_end=index_size, index_end=index_size,
pending_index_end=pending_index_size, pending_index_end=pending_index_size,
data_end=data_size, data_end=data_size,
pending_data_end=pending_data_size, pending_data_end=pending_data_size,
default_compression_header=default_compression_header, default_compression_header=default_compression_header,
) )
return docket return docket