This is an archive of the discontinued Mercurial Phabricator instance.

Status	Author	Revision
Closed	marmoute	D10776 revlog: close the index file handle after the data one
Closed	marmoute	D10775 revlog: simplify the try nesting in the `_writing` context
Closed	marmoute	D10774 revlogv2: add a `get_data` helper to grab the next piece of docket
Closed	marmoute	D10773 revlogv2: simplify and clarify the processing of each entry
Closed	marmoute	D10772 revlogv2: use a unique filename for data
Closed	marmoute	D10771 revlogv2: use a unique filename for index

Diff 28227

	transaction.add(self._indexfile, isize)			transaction.add(self._indexfile, isize)
	# exposing all file handle for writing.			# exposing all file handle for writing.
	self._writinghandles = (ifh, dfh)			self._writinghandles = (ifh, dfh)
	yield			yield
	if self._docket is not None:			if self._docket is not None:
	self._write_docket(transaction)			self._write_docket(transaction)
	finally:			finally:
	self._writinghandles = None			self._writinghandles = None
	if ifh is not None:
	ifh.close()
	if dfh is not None:			if dfh is not None:
	dfh.close()			dfh.close()
				# closing the index file last to avoid exposing referent to
				# potential unflushed data content.
				if ifh is not None:
				ifh.close()

	def _write_docket(self, transaction):			def _write_docket(self, transaction):
	"""write the current docket on disk			"""write the current docket on disk

	Exist as a method to help changelog to implement transaction logic			Exist as a method to help changelog to implement transaction logic

	We could also imagine using the same transaction logic for all revlog			We could also imagine using the same transaction logic for all revlog
	since docket are cheap."""			since docket are cheap."""