Page MenuHomePhabricator

benchmarks: restore `output` variable lost in D10884
ClosedPublic

Authored by martinvonz on Jun 22 2021, 11:32 AM.

Details

Summary

Noticed by pyflakes (which I didn't have installed for Python 3.9 when
I sent D10884).

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

martinvonz created this revision.Jun 22 2021, 11:32 AM

Doesn't this lose the ui.silent feature?

Doesn't this lose the ui.silent feature?

No, the pushbuffer+popbuffer sequence was very often used for silencing the ui, but that wasn't the (only) reason here -- the output is actually used for something. This is (AFAIK) what pushbuffer+popbuffer *should* be used for. I just missed that the output was used here when I wrote D10884.

This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.