This is an archive of the discontinued Mercurial Phabricator instance.

rhg: refactor code a little around printing of relative paths
AbandonedPublic

Authored by pulkit on Jun 25 2021, 5:34 AM.

Details

Reviewers
SimonSapin
Group Reviewers
hg-reviewers
Summary

It's easier to understand when setup to compute relative path is decoupled from
actual iteration over list of files.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

pulkit created this revision.Jun 25 2021, 5:34 AM
SimonSapin accepted this revision.Jun 29 2021, 1:25 PM
SimonSapin added a subscriber: SimonSapin.

Introducing a boolean variable in order to deduplicate very few lines doesn’t feel like much of an improvement to me, but according to your next patches this is gonna be rewritten/refactored soon anyway so let’s go ahead.

pulkit planned changes to this revision.Oct 5 2021, 7:49 AM