( )⚙ D10944 check-shbang: accept -S with env

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10944

check-shbang: accept -S with env
AbandonedPublic

Authored by marmoute on Jul 2 2021, 6:37 PM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Summary

This is useful to use python3 -u in a coming patch.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.Jul 2 2021, 6:37 PM
Alphare accepted this revision.Jul 5 2021, 5:33 AM
This revision is now accepted and ready to land.Jul 5 2021, 5:33 AM
marmoute added a comment.Jul 5 2021, 3:00 PM

-S apparently does not work on windows, so lets abandon this one.

marmoute abandoned this revision.Jul 5 2021, 4:11 PM

Revision Contents
Changeset List

PathPackages
Mtests/test-check-shbang.t (2 lines)

Diff 28750

tests/test-check-shbang.t

#require test-repo #require test-repo
$ . "$TESTDIR/helpers-testrepo.sh" $ . "$TESTDIR/helpers-testrepo.sh"
$ cd "`dirname "$TESTDIR"`" $ cd "`dirname "$TESTDIR"`"
look for python scripts that do not use /usr/bin/env look for python scripts that do not use /usr/bin/env
$ testrepohg files 'set:grep(r"^#!.*?python") and not grep(r"^#!/usr/bi{1}n/env python") - **/*.t' $ testrepohg files 'set:grep(r"^#!.*?python") and not grep(r"^#!/usr/bi{1}n/env (-S )?python") - **/*.t'
[1] [1]
In tests, enforce $PYTHON and *not* /usr/bin/env python or similar: In tests, enforce $PYTHON and *not* /usr/bin/env python or similar:
$ testrepohg files 'set:grep(r"#!.*?python") and **/*.t' \ $ testrepohg files 'set:grep(r"#!.*?python") and **/*.t' \
> -X tests/test-check-execute.t \ > -X tests/test-check-execute.t \
> -X tests/test-check-format.t \ > -X tests/test-check-format.t \
> -X tests/test-check-module-imports.t \ > -X tests/test-check-module-imports.t \
> -X tests/test-check-pyflakes.t \ > -X tests/test-check-pyflakes.t \