This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1096

releasenotes: make the import of fuzzywuzzy optional
ClosedPublic

Authored by pulkit on Oct 15 2017, 11:14 AM.

Details

Reviewers
yuja
Group Reviewers
hg-reviewers
Commits
rHG44bd29168d14: releasenotes: make the import of fuzzywuzzy optional
Summary

If fuzzywuzzy is note present, we will not be having the capability to merge
existing releasenotes with the new releasenotes on the similarity basis.
The merging will still work good for exact same releasenotes entries.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Oct 15 2017, 11:14 AM
yuja requested changes to this revision.Oct 16 2017, 9:05 AM
yuja added a subscriber: yuja.
yuja added inline comments.
hgext/releasenotes.py
222

Needs to evaluate the fuzz module to get around the demandimport.

e.g.

try:
    from fuzzywuzzy import fuzz
    fuzz.token_set_ratio
except ImportError
224

Perhaps it should return True.

Any maybe it should show warning, status or debug message?

This revision now requires changes to proceed.Oct 16 2017, 9:05 AM
pulkit added inline comments.Oct 16 2017, 10:18 AM
hgext/releasenotes.py
224

Yes it should return True and I think the doc of this function is wrong. Nice catch.

pulkit added inline comments.Oct 16 2017, 10:24 AM
hgext/releasenotes.py
224

Also, whatever message we will use here, warning, status or debug, it will be repeated a lot of times as the function is called a lot of times. This extension need some cleanup. :(

pulkit marked 2 inline comments as done.Oct 16 2017, 2:30 PM
yuja accepted this revision.Oct 17 2017, 9:44 AM
This revision is now accepted and ready to land.Oct 17 2017, 9:44 AM
Closed by commit rHG44bd29168d14: releasenotes: make the import of fuzzywuzzy optional (authored by pulkit). · Explain WhyOct 17 2017, 10:16 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/releasenotes.py (7 lines)

Diff 2912

hgext/releasenotes.py

return False return False
else: else:
return False return False
def similaritycheck(incoming_str, existingnotes): def similaritycheck(incoming_str, existingnotes):
""" """
Returns false when note fragment can be merged to existing notes. Returns false when note fragment can be merged to existing notes.
""" """
try:
import fuzzywuzzy.fuzz as fuzz import fuzzywuzzy.fuzz as fuzz
yujaUnsubmitted
Done

Needs to evaluate the fuzz module to get around the demandimport.

e.g.

try:
    from fuzzywuzzy import fuzz
    fuzz.token_set_ratio
except ImportError
yuja: Needs to evaluate the fuzz module to get around the demandimport. e.g. ``` try: from…
fuzz.token_set_ratio
except ImportError:
yujaUnsubmitted
Done

Perhaps it should return True.

Any maybe it should show warning, status or debug message?

yuja: Perhaps it should return True. Any maybe it should show warning, status or debug message?
pulkitAuthorUnsubmitted
Not Done

Yes it should return True and I think the doc of this function is wrong. Nice catch.

pulkit: Yes it should return True and I think the doc of this function is wrong. Nice catch.
pulkitAuthorUnsubmitted
Not Done

Also, whatever message we will use here, warning, status or debug, it will be repeated a lot of times as the function is called a lot of times. This extension need some cleanup. :(

pulkit: Also, whatever message we will use here, warning, status or debug, it will be repeated a lot of…
return True
merge = True merge = True
for bullet in existingnotes: for bullet in existingnotes:
score = fuzz.token_set_ratio(incoming_str, bullet) score = fuzz.token_set_ratio(incoming_str, bullet)
if score > 75: if score > 75:
merge = False merge = False
break break
return merge return merge