( )⚙ D1097 releasenotes: don't abort is there is a bad formatted entry for releasenotes

This is an archive of the discontinued Mercurial Phabricator instance.

releasenotes: don't abort is there is a bad formatted entry for releasenotes
ClosedPublic

Authored by pulkit on Oct 15 2017, 11:15 AM.

Details

Summary

While producing releasenotes for (4.3::), releasenotes aborts with error because
of some bad formatting of releasenotes in some commits. Instead of aborting,
this adds warning message which will help us in skipping them and telling user
about it.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit created this revision.Oct 15 2017, 11:15 AM
yuja requested changes to this revision.Oct 16 2017, 9:07 AM
yuja added a subscriber: yuja.
yuja added inline comments.
hgext/releasenotes.py
337–338

warn() seems better.

This revision now requires changes to proceed.Oct 16 2017, 9:07 AM
pulkit edited the summary of this revision. (Show Details)Oct 16 2017, 2:29 PM
pulkit updated this revision to Diff 2833.
pulkit marked an inline comment as done.Oct 16 2017, 2:30 PM
yuja accepted this revision.Oct 17 2017, 9:44 AM
This revision is now accepted and ready to land.Oct 17 2017, 9:44 AM
This revision was automatically updated to reflect the committed changes.