This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11005

remotefilelog: tweak corrupt cache test to grep more flexibly
ClosedPublic

Authored by durin42 on Jul 7 2021, 2:12 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG5830539c46be: remotefilelog: tweak corrupt cache test to grep more flexibly
Summary

I'm about to fix the abuse of RuntimeError here, which breaks the test
if I don't do this.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Jul 7 2021, 2:12 PM
pulkit accepted this revision.Jul 8 2021, 4:02 AM
This revision is now accepted and ready to land.Jul 8 2021, 4:02 AM
pulkit added a comment.EditedJul 8 2021, 5:44 AM

This makes the test fail on Python 2.

Revision Contents
Changeset List

Diff 28973

tests/test-remotefilelog-corrupt-cache.t

$ hg up -q null $ hg up -q null
$ cat >> .hg/hgrc <<EOF $ cat >> .hg/hgrc <<EOF
> [remotefilelog] > [remotefilelog]
> validatecache=off > validatecache=off
> EOF > EOF
$ chmod u+w $CACHEDIR/master/11/f6ad8ec52a2984abaafd7c3b516503785c2072/1406e74118627694268417491f018a4a883152f0 $ chmod u+w $CACHEDIR/master/11/f6ad8ec52a2984abaafd7c3b516503785c2072/1406e74118627694268417491f018a4a883152f0
$ echo x > $CACHEDIR/master/11/f6ad8ec52a2984abaafd7c3b516503785c2072/1406e74118627694268417491f018a4a883152f0 $ echo x > $CACHEDIR/master/11/f6ad8ec52a2984abaafd7c3b516503785c2072/1406e74118627694268417491f018a4a883152f0
$ hg up tip 2>&1 | egrep "^RuntimeError" $ hg up tip 2>&1 | egrep "^[^ ].*unexpected remotefilelog"
RuntimeError: unexpected remotefilelog header: illegal format RuntimeError: unexpected remotefilelog header: illegal format
Verify detection and remediation when remotefilelog.validatecachelog is set Verify detection and remediation when remotefilelog.validatecachelog is set
$ cat >> .hg/hgrc <<EOF $ cat >> .hg/hgrc <<EOF
> [remotefilelog] > [remotefilelog]
> validatecachelog=$PWD/.hg/remotefilelog_cache.log > validatecachelog=$PWD/.hg/remotefilelog_cache.log
> validatecache=strict > validatecache=strict