This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11102

testing: do not stop waiting if timeout is 0 (issue6541)
ClosedPublic

Authored by ced on Jul 17 2021, 6:48 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG1bad89a67745: testing: do not stop waiting if timeout is 0 (issue6541)

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ced created this revision.Jul 17 2021, 6:48 AM
pulkit accepted this revision.Jul 18 2021, 5:33 AM
This revision is now accepted and ready to land.Jul 18 2021, 5:33 AM
ced added a commit: rHG1bad89a67745: testing: do not stop waiting if timeout is 0 (issue6541).Jul 19 2021, 9:16 AM
Closed by commit rHG1bad89a67745: testing: do not stop waiting if timeout is 0 (issue6541) (authored by ced). · Explain Why
This revision was automatically updated to reflect the committed changes.
marmoute added a subscriber: marmoute.Jul 19 2021, 12:13 PM

Note: we should probably fallback to some default long timeout (like 30 secondes) instead of blocking for ever here.

ced added a comment.Jul 19 2021, 12:23 PM
In D11102#171260, @marmoute wrote:

Note: we should probably fallback to some default long timeout (like 30 secondes) instead of blocking for ever here.

I found the problem because I wanted to enable test on the Gentoo build but I can not know which timeout will work for all the various platforms and hardware.
So I set the timeout to 0 but this is run only on releases which should have all tests passed normally :-)
Also disabling the timeout will be requested explicitly by the user so he should expect blocking.

Revision Contents
Changeset List

PathPackages
Mmercurial/testing/__init__.py (2 lines)

Diff 29439

mercurial/testing/__init__.py

return 1 return 1
return current / float(default) return current / float(default)
def wait_file(path, timeout=10): def wait_file(path, timeout=10):
timeout *= _timeout_factor() timeout *= _timeout_factor()
start = time.time() start = time.time()
while not os.path.exists(path): while not os.path.exists(path):
if time.time() - start > timeout: if timeout and time.time() - start > timeout:
raise RuntimeError(b"timed out waiting for file: %s" % path) raise RuntimeError(b"timed out waiting for file: %s" % path)
time.sleep(0.01) time.sleep(0.01)
def write_file(path, content=b''): def write_file(path, content=b''):
with open(path, 'wb') as f: with open(path, 'wb') as f:
f.write(content) f.write(content)