( )โš™ D11205 test: remove `sleep` usage in `test-nointerrupt.t` (issue6271)

This is an archive of the discontinued Mercurial Phabricator instance.

test: remove `sleep` usage in `test-nointerrupt.t` (issue6271)
ClosedPublic

Authored by marmoute on Jul 20 2021, 9:45 PM.

Details

Summary

We move from sleep based synchronisation to file creation based synchronisation.

Sleeps is the path to the dark side.
Sleeps leads to flakiness.
Flakiness leads to anger.
Anger leads to hate.
Hate leads to suffering.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Jul 20 2021, 9:45 PM
baymax updated this revision to Diff 29706.Jul 21 2021, 7:30 PM

โœ… refresh by Heptapod after a successful CI run (๐Ÿ™ ๐Ÿ’š)
โš  This patch is intended for stable โš 

Alphare accepted this revision.Jul 22 2021, 12:08 PM
Alphare added a subscriber: Alphare.

Does rhg still fail with this new mechanism? I'm assuming it does because nothing changed on its side, but we wouldn't want to lose the reproduction case.

This revision is now accepted and ready to land.Jul 22 2021, 12:08 PM