Page MenuHomePhabricator

obsolete: disable other evolution config options if createmarkers is off
ClosedPublic

Authored by av6 on Jul 28 2021, 8:32 AM.

Details

Summary

We used to raise an abort in this case, but recent changes to local clone
command (377d8fc20e34) resulted in destrepo both caring about
experimental.evolution config options and not initializing extensions.

So imagine if you had evolve and allowdivergence enabled in your ~/.hgrc. Local
clone stopped working after 377d8fc20e34 because evolve sets
experimental.evolution=all, but only on srcrepo, for destrepo the extension is
not initialized. It's possible to make local cloning work by initializing
extensions for destrepo in some cases, but in other cases (e.g. allowdivergence
in ~/.hgrc, evolve extension in original-repo/.hg/hgrc) it would still fail.

In a discussion with Pierre-Yves David it was decided to simply force other
evolution options to be false if createmarkers is not enabled.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

av6 created this revision.Jul 28 2021, 8:32 AM
marmoute accepted this revision.Jul 28 2021, 10:42 AM
marmoute added a subscriber: marmoute.

This looks like a saner behavior.

This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.