Page MenuHomePhabricator

windows: avoid a bytes vs unicode crash reading passwords on py2
AbandonedPublic

Authored by Alphare on Aug 2 2021, 11:00 AM.

Details

Reviewers
marmoute
mharbison72
Group Reviewers
hg-reviewers
Summary

This broke in 5b3513177f2b. Specifically, after typing in the password on py2,
it would crash with:

TypeError: putwch() argument 1 must be cannot convert raw buffers, not str

Diff Detail

Repository
rHG Mercurial
Branch
stable
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

mharbison72 created this revision.Aug 2 2021, 11:00 AM
marmoute accepted this revision.Aug 2 2021, 2:23 PM
marmoute added a subscriber: marmoute.

seems fine. I assume this needs to go to stable.

This got published as 064cd182555f, without the differential URL. Probably another reviewer needs to accept/close it, because that's not an option for me.

Alphare commandeered this revision.
Alphare abandoned this revision.

This was taken and is now public.