( )⚙ D11241 pytype: add assertions to explain revlogv2 invariants to Pytype

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11241

pytype: add assertions to explain revlogv2 invariants to Pytype
ClosedPublic

Authored by Alphare on Aug 2 2021, 12:48 PM.

Details

Reviewers
marmoute
Group Reviewers
hg-reviewers
Commits
rHG60ccc86a12f3: pytype: add assertions to explain revlogv2 invariants to Pytype

Diff Detail

Repository
rHG Mercurial
Branch
stable
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

Alphare created this revision.Aug 2 2021, 12:48 PM
marmoute accepted this revision.Aug 2 2021, 2:18 PM
Alphare added a commit: rHG60ccc86a12f3: pytype: add assertions to explain revlogv2 invariants to Pytype.Aug 2 2021, 10:11 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG60ccc86a12f3: pytype: add assertions to explain revlogv2 invariants to Pytype (authored by Alphare). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/revlog.py (4 lines)

Diff 29773

mercurial/revlog.py

else: else:
dfh.seek(self._docket.data_end, os.SEEK_SET) dfh.seek(self._docket.data_end, os.SEEK_SET)
except IOError as inst: except IOError as inst:
if inst.errno != errno.ENOENT: if inst.errno != errno.ENOENT:
raise raise
dfh = self._datafp(b"w+") dfh = self._datafp(b"w+")
transaction.add(self._datafile, dsize) transaction.add(self._datafile, dsize)
if self._sidedatafile is not None: if self._sidedatafile is not None:
# revlog-v2 does not inline, help Pytype
assert dfh is not None
try: try:
sdfh = self.opener(self._sidedatafile, mode=b"r+") sdfh = self.opener(self._sidedatafile, mode=b"r+")
dfh.seek(self._docket.sidedata_end, os.SEEK_SET) dfh.seek(self._docket.sidedata_end, os.SEEK_SET)
except IOError as inst: except IOError as inst:
if inst.errno != errno.ENOENT: if inst.errno != errno.ENOENT:
raise raise
sdfh = self.opener(self._sidedatafile, mode=b"w+") sdfh = self.opener(self._sidedatafile, mode=b"w+")
transaction.add( transaction.add(
offset += curr * self.index.entry_size offset += curr * self.index.entry_size
transaction.add(self._indexfile, offset) transaction.add(self._indexfile, offset)
ifh.write(entry) ifh.write(entry)
ifh.write(data[0]) ifh.write(data[0])
ifh.write(data[1]) ifh.write(data[1])
assert not sidedata assert not sidedata
self._enforceinlinesize(transaction) self._enforceinlinesize(transaction)
if self._docket is not None: if self._docket is not None:
# revlog-v2 always has 3 writing handles, help Pytype
assert self._writinghandles[2] is not None
self._docket.index_end = self._writinghandles[0].tell() self._docket.index_end = self._writinghandles[0].tell()
self._docket.data_end = self._writinghandles[1].tell() self._docket.data_end = self._writinghandles[1].tell()
self._docket.sidedata_end = self._writinghandles[2].tell() self._docket.sidedata_end = self._writinghandles[2].tell()
nodemaputil.setup_persistent_nodemap(transaction, self) nodemaputil.setup_persistent_nodemap(transaction, self)
def addgroup( def addgroup(
self, self,