This is an archive of the discontinued Mercurial Phabricator instance.

test-nointerrupt: make "sure" the handler "might" trigger (issue6558)
ClosedPublic

Authored by marmoute on Aug 4 2021, 6:37 AM.

Details

Summary

We are sure that the signal got sent in the right time frame, however, we still
have race, so either the code is actually buggy or we need some security to make
sure the signal get processed.

We might be affected by https://bugs.python.org/issue43406 ?

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Aug 4 2021, 6:37 AM
Alphare added a subscriber: Alphare.Aug 5 2021, 3:22 AM

Has this resulted in the flakiness disappearing (at least as far as you can tell)?

Has this resulted in the flakiness disappearing (at least as far as you can tell)?

as far as I could tell.

Alphare accepted this revision.Aug 5 2021, 12:03 PM

That's pretty sad, but it's still arguably a better state than before.

This revision is now accepted and ready to land.Aug 5 2021, 12:03 PM