This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11304

pyoxidizer: disable the test for disabled & broken extensions help
ClosedPublic

Authored by marmoute on Aug 18 2021, 3:48 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGd88f4231712c: pyoxidizer: disable the test for disabled & broken extensions help
Summary

The test is a bit fragile and the feature is significantly broken for 3rd party
extension already. So we disable that section with a comment about why and what
is needed.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Aug 18 2021, 3:48 PM
marmoute added a commit: rHGd88f4231712c: pyoxidizer: disable the test for disabled & broken extensions help.Aug 18 2021, 9:20 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHGd88f4231712c: pyoxidizer: disable the test for disabled & broken extensions help (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-extension.t (16 lines)

Diff 29954

tests/test-extension.t

flags)}" flags)}"
You can set patchbomb to always ask for confirmation by setting You can set patchbomb to always ask for confirmation by setting
"patchbomb.confirm" to true. "patchbomb.confirm" to true.
(use 'hg help extensions' for information on enabling extensions) (use 'hg help extensions' for information on enabling extensions)
Help can find unimported extensions
-----------------------------------
XXX-PYOXIDIZER since the frozen binary does not have source directory tree,
this make the checking for actual file under `hgext` a bit complicated. In
addition these tests do some strange dance to ensure some other module are the
first in `sys.path` (since the current install path is always in front
otherwise) that are fragile and that does not match reality in the field. So
for now we disable this test untill a deeper rework of that logic is done.
#if no-pyoxidizer
Broken disabled extension and command: Broken disabled extension and command:
$ mkdir hgext $ mkdir hgext
$ echo > hgext/__init__.py $ echo > hgext/__init__.py
$ cat > hgext/broken.py <<NO_CHECK_EOF $ cat > hgext/broken.py <<NO_CHECK_EOF
> "broken extension' > "broken extension'
> NO_CHECK_EOF > NO_CHECK_EOF
$ cat > path.py <<EOF $ cat > path.py <<EOF
> def g(): > def g():
> pass > pass
> EOF > EOF
$ hg --config extensions.path=./path.py help foo $ hg --config extensions.path=./path.py help foo
abort: no such help topic: foo abort: no such help topic: foo
(try 'hg help --keyword foo') (try 'hg help --keyword foo')
[255] [255]
#endif
---
$ cat > throw.py <<EOF $ cat > throw.py <<EOF
> from mercurial import commands, registrar, util > from mercurial import commands, registrar, util
> cmdtable = {} > cmdtable = {}
> command = registrar.command(cmdtable) > command = registrar.command(cmdtable)
> class Bogon(Exception): pass > class Bogon(Exception): pass
> # NB: version should be bytes; simulating extension not ported to py3 > # NB: version should be bytes; simulating extension not ported to py3
> __version__ = '1.0.0' > __version__ = '1.0.0'
> @command(b'throw', [], b'hg throw', norepo=True) > @command(b'throw', [], b'hg throw', norepo=True)