Page MenuHomePhabricator

pyoxidized: adapt test-devel-warnings.t
ClosedPublic

Authored by marmoute on Aug 17 2021, 3:34 PM.

Details

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Aug 17 2021, 3:34 PM
mharbison72 added inline comments.
tests/test-devel-warnings.t
160

Is pyoxidizer and chg mutually exclusive? I'm guessing not because of the changes above, but don't know if you need no-chg here.

marmoute added inline comments.Aug 18 2021, 5:02 AM
tests/test-devel-warnings.t
160

They are not, but we don't test this combination, especially because --chg is not supported on windows and --pyoxidized is not supported outside of windows.

So I expect this section to have divergent output if someone get it to run with both chg and pyoxidizer and an extra clause we will be required.

Adding no-chg now would simply silently omit that part which seems bad.

baymax updated this revision to Diff 29913.Aug 18 2021, 7:01 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)
⚠ This patch is intended for stable ⚠

This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.