Page MenuHomePhabricator

clone: properly create target directories during local clone (issue6581)
ClosedPublic

Authored by marmoute on Aug 25 2021, 5:41 AM.

Details

Summary

The store encoding was mudding the water. This lead to local clone crashing for
file with long filename as their destination directory needed to be encoded.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Aug 25 2021, 5:41 AM

It need minor fixing for a couple of test output. Update coming.

marmoute planned changes to this revision.Aug 25 2021, 6:09 AM
Alphare added inline comments.
mercurial/streamclone.py
824–828

Not 100% sure what "put them off" means in this context

marmoute updated this revision to Diff 30015.Aug 25 2021, 6:32 AM
baymax updated this revision to Diff 30016.Aug 25 2021, 8:09 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)
⚠ This patch is intended for stable ⚠

Looking at https://phab.mercurial-scm.org/D11340?vs=30015&id=30016#toc, it looks like Baymax refreshed with the older diff, since the older CI run took a lot more time to finish than the correct one.

This is because I think f6879956a386 made it so we still phabupdate when the tests break, which seems like a very dangerous thing. @marmoute am I wrong?

For this series, I see that 7b5827f1a199 is the correct one (I have it from the Heptapod repo), so I'll take that directly.

Alphare accepted this revision.Aug 25 2021, 9:04 AM

Accepting the "previous" revision as per my previous comment

This revision is now accepted and ready to land.Aug 25 2021, 9:04 AM

Looking at https://phab.mercurial-scm.org/D11340?vs=30015&id=30016#toc, it looks like Baymax refreshed with the older diff, since the older CI run took a lot more time to finish than the correct one.
This is because I think f6879956a386 made it so we still phabupdate when the tests break, which seems like a very dangerous thing. @marmoute am I wrong?

Urg, probably. Let me follow up with a fix.