( )⚙ D11424 dirstate: directly call the right function in `set_tracked`

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11424

dirstate: directly call the right function in `set_tracked`
ClosedPublic

Authored by marmoute on Sep 16 2021, 10:42 AM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHG6255a0d33c45: dirstate: directly call the right function in `set_tracked`
Summary

This get use closer to removing some older API on the dirstate.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Sep 16 2021, 10:42 AM
Alphare accepted this revision.Sep 20 2021, 5:56 AM
This revision is now accepted and ready to land.Sep 20 2021, 5:56 AM

Revision Contents
Changeset List

PathPackages
Mmercurial/dirstate.py (5 lines)

Diff 30306

mercurial/dirstate.py

def set_tracked(self, filename): def set_tracked(self, filename):
"""a "public" method for generic code to mark a file as tracked """a "public" method for generic code to mark a file as tracked
This function is to be called outside of "update/merge" case. For This function is to be called outside of "update/merge" case. For
example by a command like `hg add X`. example by a command like `hg add X`.
return True the file was previously untracked, False otherwise. return True the file was previously untracked, False otherwise.
""" """
self._dirty = True
self._updatedfiles.add(filename)
entry = self._map.get(filename) entry = self._map.get(filename)
if entry is None: if entry is None:
self._add(filename) self._check_new_tracked_filename(filename)
self._map.addfile(filename, added=True)
return True return True
elif not entry.tracked: elif not entry.tracked:
self._normallookup(filename) self._normallookup(filename)
return True return True
# XXX This is probably overkill for more case, but we need this to # XXX This is probably overkill for more case, but we need this to
# fully replace the `normallookup` call with `set_tracked` one. # fully replace the `normallookup` call with `set_tracked` one.
# Consider smoothing this in the future. # Consider smoothing this in the future.
self.set_possibly_dirty(filename) self.set_possibly_dirty(filename)