( )⚙ D11435 dirstate: drop the `_addpath` method

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11435

dirstate: drop the `_addpath` method
ClosedPublic

Authored by marmoute on Sep 16 2021, 10:44 AM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHGe7d0a511965c: dirstate: drop the `_addpath` method
Summary

All user have been migrated.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Sep 16 2021, 10:44 AM
Alphare accepted this revision.Sep 20 2021, 9:45 AM
This revision is now accepted and ready to land.Sep 20 2021, 9:45 AM
marmoute added a commit: rHGe7d0a511965c: dirstate: drop the `_addpath` method.Sep 20 2021, 10:08 AM
Closed by commit rHGe7d0a511965c: dirstate: drop the `_addpath` method (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/dirstate.py (27 lines)

Diff 30317

mercurial/dirstate.py

parentfiledata is not None parentfiledata is not None
and parentfiledata[2] > self._lastnormaltime and parentfiledata[2] > self._lastnormaltime
): ):
# Remember the most recent modification timeslot for status(), # Remember the most recent modification timeslot for status(),
# to make sure we won't miss future size-preserving file content # to make sure we won't miss future size-preserving file content
# modifications that happen within the same timeslot. # modifications that happen within the same timeslot.
self._lastnormaltime = parentfiledata[2] self._lastnormaltime = parentfiledata[2]
def _addpath(
self,
f,
mode=0,
size=None,
mtime=None,
added=False,
merged=False,
from_p2=False,
possibly_dirty=False,
):
entry = self._map.get(f)
if added or entry is not None and not entry.tracked:
self._check_new_tracked_filename(f)
self._dirty = True
self._updatedfiles.add(f)
self._map.addfile(
f,
mode=mode,
size=size,
mtime=mtime,
added=added,
merged=merged,
from_p2=from_p2,
possibly_dirty=possibly_dirty,
)
def _check_new_tracked_filename(self, filename): def _check_new_tracked_filename(self, filename):
scmutil.checkfilename(filename) scmutil.checkfilename(filename)
if self._map.hastrackeddir(filename): if self._map.hastrackeddir(filename):
msg = _(b'directory %r already in dirstate') msg = _(b'directory %r already in dirstate')
msg %= pycompat.bytestr(filename) msg %= pycompat.bytestr(filename)
raise error.Abort(msg) raise error.Abort(msg)
# shadows # shadows
for d in pathutil.finddirs(filename): for d in pathutil.finddirs(filename):