This is an archive of the discontinued Mercurial Phabricator instance.

rust: Remove EntryState::Unknown
ClosedPublic

Authored by SimonSapin on Sep 20 2021, 6:17 PM.

Details

Summary

This enum variant represented the state == '?' case, which was used
to represent the absence of a dirstate entry/item (and therefore of that
entry’s state).

Now that previous refactors have removed this use in the Python/Rust
FFI APIs, the remaining uses can be removed by replacing EntryState
by Option<EntryState> where appropriate, using None to represent
the absence of an entry.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

SimonSapin created this revision.Sep 20 2021, 6:17 PM
Alphare accepted this revision.Sep 22 2021, 4:10 AM
This revision is now accepted and ready to land.Sep 22 2021, 4:10 AM
This revision was automatically updated to reflect the committed changes.