Page MenuHomePhabricator

dirstate: Pass the final DirstateItem to _rustmap.addfile()
ClosedPublic

Authored by SimonSapin on Sep 23 2021, 1:42 PM.

Details

Summary

Now that the Python DirstateItem class wraps a Rust DirstateEntry value,
use that value directly instead of converting through v1 data + 5 booleans.

Also remove propogating the return value. None of the callers look at it,
and it is always None.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

SimonSapin created this revision.Sep 23 2021, 1:42 PM
Alphare accepted this revision.Sep 24 2021, 5:59 AM
This revision is now accepted and ready to land.Sep 24 2021, 5:59 AM
SimonSapin edited the summary of this revision. (Show Details)Sep 24 2021, 9:26 AM
SimonSapin updated this revision to Diff 30399.