( )⚙ D11611 largefiles: add tr backup for largefilesdirstate

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11611

largefiles: add tr backup for largefilesdirstate
ClosedPublic

Authored by pulkit on Oct 5 2021, 7:43 AM.

Details

Reviewers
martinvonz
Group Reviewers
hg-reviewers
Commits
rHG1e98f9b5bc71: largefiles: add tr backup for largefilesdirstate
Summary

This will help us in automatically restoring the largefilesdirstate if a
transaction is rolled back.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Oct 5 2021, 7:43 AM
martinvonz accepted this revision.Oct 8 2021, 4:53 PM
This revision is now accepted and ready to land.Oct 8 2021, 4:53 PM
pulkit added a commit: rHG1e98f9b5bc71: largefiles: add tr backup for largefilesdirstate.Oct 8 2021, 7:02 PM
Closed by commit rHG1e98f9b5bc71: largefiles: add tr backup for largefilesdirstate (authored by pulkit). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 30692

hgext/largefiles/lfutil.py

def _ignore(self, f): def _ignore(self, f):
return False return False
def write(self, tr): def write(self, tr):
# (1) disable PENDING mode always # (1) disable PENDING mode always
# (lfdirstate isn't yet managed as a part of the transaction) # (lfdirstate isn't yet managed as a part of the transaction)
# (2) avoid develwarn 'use dirstate.write with ....' # (2) avoid develwarn 'use dirstate.write with ....'
if tr:
tr.addbackup(b'largefiles/dirstate', location=b'plain')
super(largefilesdirstate, self).write(None) super(largefilesdirstate, self).write(None)
def openlfdirstate(ui, repo, create=True): def openlfdirstate(ui, repo, create=True):
""" """
Return a dirstate object that tracks largefiles: i.e. its root is Return a dirstate object that tracks largefiles: i.e. its root is
the repo root, but it is saved in .hg/largefiles/dirstate. the repo root, but it is saved in .hg/largefiles/dirstate.
""" """

tests/test-largefiles-cache.t

share source's local store. Avoid the extra largefiles added in the unix share source's local store. Avoid the extra largefiles added in the unix
conditional above. conditional above.
$ hash=`hg -R share_dst cat share_dst/.hglf/large` $ hash=`hg -R share_dst cat share_dst/.hglf/large`
$ echo $hash $ echo $hash
e2fb5f2139d086ded2cb600d5a91a196e76bf020 e2fb5f2139d086ded2cb600d5a91a196e76bf020
$ find share_dst/.hg/largefiles/* | sort $ find share_dst/.hg/largefiles/* | sort
share_dst/.hg/largefiles/dirstate share_dst/.hg/largefiles/dirstate
share_dst/.hg/largefiles/undo.backup.dirstate
$ find src/.hg/largefiles/* | egrep "(dirstate|$hash)" | sort $ find src/.hg/largefiles/* | egrep "(dirstate|$hash)" | sort
src/.hg/largefiles/dirstate src/.hg/largefiles/dirstate
src/.hg/largefiles/e2fb5f2139d086ded2cb600d5a91a196e76bf020 src/.hg/largefiles/e2fb5f2139d086ded2cb600d5a91a196e76bf020
src/.hg/largefiles/undo.backup.dirstate
Verify that backwards compatibility is maintained for old storage layout Verify that backwards compatibility is maintained for old storage layout
$ mv src/.hg/largefiles/$hash share_dst/.hg/largefiles $ mv src/.hg/largefiles/$hash share_dst/.hg/largefiles
$ hg verify --quiet --lfa -R share_dst --config largefiles.usercache= $ hg verify --quiet --lfa -R share_dst --config largefiles.usercache=
Inject corruption into the largefiles store and see how update handles that: Inject corruption into the largefiles store and see how update handles that:
$ cd src $ cd src