This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11619

hg: let extensions call the func without populating opts keys
ClosedPublic

Authored by khanchi97 on Oct 8 2021, 7:33 AM.

Details

Reviewers
martinvonz
Group Reviewers
hg-reviewers
Commits
rHG1d70fb83ff4a: hg: let extensions call the func without populating opts keys
Summary

This change is to help extensions by not forcing them to populate with
opts[b'bundle'] and opts[b'force'] when calling hg.incoming(...)

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

khanchi97 created this revision.Oct 8 2021, 7:33 AM
martinvonz requested changes to this revision.Oct 8 2021, 4:45 PM
martinvonz added a subscriber: martinvonz.

This needs a clearer commit message. I *think* what you mean is that you're doing this in order to let extensions call these functions without populating the opts[b"bundle"] etc. However, does your extension really want to call debugbackupbundle()? Or do the KeyErrors actually happen when you simply run some hg commands? Which ones?

This revision now requires changes to proceed.Oct 8 2021, 4:45 PM
khanchi97 added a comment.Oct 9 2021, 12:24 AM
In D11619#178056, @martinvonz wrote:

This needs a clearer commit message. I *think* what you mean is that you're doing this in order to let extensions call these functions without populating the opts[b"bundle"] etc.

Yes. I will change the commit message.

However, does your extension really want to call debugbackupbundle()?

No. The extension don't intend to call debugbackupbundle(). I just thought it's no harm to make the change here as well. I'll undo it.

khanchi97 retitled this revision from hg: use dict.get() instead, to prevent KeyError to hg: let extensions call the func without populating opts keys.Oct 9 2021, 12:25 AM
khanchi97 edited the summary of this revision. (Show Details)
khanchi97 updated this revision to Diff 30697.
khanchi97 added a commit: rHG1d70fb83ff4a: hg: let extensions call the func without populating opts keys.Oct 9 2021, 1:12 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG1d70fb83ff4a: hg: let extensions call the func without populating opts keys (authored by khanchi97). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/hg.py (2 lines)

Diff 30698

mercurial/hg.py

cleanupfn = other.close cleanupfn = other.close
try: try:
ui.status(_(b'comparing with %s\n') % urlutil.hidepassword(source)) ui.status(_(b'comparing with %s\n') % urlutil.hidepassword(source))
revs, checkout = addbranchrevs(repo, other, branches, opts.get(b'rev')) revs, checkout = addbranchrevs(repo, other, branches, opts.get(b'rev'))
if revs: if revs:
revs = [other.lookup(rev) for rev in revs] revs = [other.lookup(rev) for rev in revs]
other, chlist, cleanupfn = bundlerepo.getremotechanges( other, chlist, cleanupfn = bundlerepo.getremotechanges(
ui, repo, other, revs, opts[b"bundle"], opts[b"force"] ui, repo, other, revs, opts.get(b"bundle"), opts.get(b"force")
) )
if not chlist: if not chlist:
ui.status(_(b"no changes found\n")) ui.status(_(b"no changes found\n"))
return subreporecurse() return subreporecurse()
ui.pager(b'incoming') ui.pager(b'incoming')
displayer = logcmdutil.changesetdisplayer( displayer = logcmdutil.changesetdisplayer(
ui, other, opts, buffered=buffered ui, other, opts, buffered=buffered