This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11626

dispatch: don't change error status if flushing stdio fails
ClosedPublic

Authored by martinvonz on Oct 11 2021, 7:30 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG8fae2cc6ee86: dispatch: don't change error status if flushing stdio fails
Summary

If we already have a non-zero exit code, I don't think we should
change it to 255 because we fail to flush stdio. This may not matter
yet, but it will matter when I make a killed pager result in exit code
250 (it's currently 255).

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Oct 11 2021, 7:30 PM
pulkit accepted this revision.Oct 12 2021, 9:20 AM
This revision is now accepted and ready to land.Oct 12 2021, 9:20 AM

Revision Contents
Changeset List

PathPackages
Mmercurial/dispatch.py (2 lines)

Diff 30745

mercurial/dispatch.py

err = None err = None
try: try:
status = _rundispatch(req) status = _rundispatch(req)
except error.StdioError as e: except error.StdioError as e:
err = e err = e
status = -1 status = -1
ret = _flushstdio(req.ui, err) ret = _flushstdio(req.ui, err)
if ret: if ret and not status:
status = ret status = ret
return status return status
def _rundispatch(req): def _rundispatch(req):
with tracing.log('dispatch._rundispatch'): with tracing.log('dispatch._rundispatch'):
if req.ferr: if req.ferr:
ferr = req.ferr ferr = req.ferr