( )⚙ D1164 extensions: always include traceback when extension setup fails

This is an archive of the discontinued Mercurial Phabricator instance.

extensions: always include traceback when extension setup fails
ClosedPublic

Authored by martinvonz on Oct 17 2017, 2:24 PM.

Details

Summary

I have spent a lot of time debugging extensions that failed to load
because we don't include a traceback and I didn't realize I could get
traceback for the extension failure with --traceback. Let's just turn
them on by default, since it should be rare that the user sees these
tracebacks anyway (and if they do, it's not so bad if the extra
traceback pushes them a little harder to report the problem).

Since we already had a test case with --traceback and one without, I
just removed the one with the flag.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

martinvonz created this revision.Oct 17 2017, 2:24 PM
quark accepted this revision.Oct 17 2017, 7:37 PM
This revision was automatically updated to reflect the committed changes.